leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3ae11c90fd
linux/drivers/scsi/fnic
History
Chris Leech e09056b25c [SCSI] fnic: BUG: sleeping function called from invalid context during probe 
I hit this during driver probe with the latest fnic updates (this trace
is from a backport into a distro kernel, but the issue is the same).

> BUG: sleeping function called from invalid context at mm/slab.c:3113
> in_atomic(): 0, irqs_disabled(): 1, pid: 610, name: work_for_cpu
> INFO: lockdep is turned off.
> irq event stamp: 0
> hardirqs last  enabled at (0): [<(null)>] (null)
> hardirqs last disabled at (0): [<ffffffff81070aa5>]
> copy_process+0x5e5/0x1670
> softirqs last  enabled at (0): [<ffffffff81070aa5>]
> copy_process+0x5e5/0x1670
> softirqs last disabled at (0): [<(null)>] (null)
> Pid: 610, comm: work_for_cpu Not tainted
> Call Trace:
>  [<ffffffff810b2d10>] ? print_irqtrace_events+0xd0/0xe0
>  [<ffffffff8105c1a7>] ? __might_sleep+0xf7/0x130
>  [<ffffffff81184efb>] ? kmem_cache_alloc_trace+0x20b/0x2d0
>  [<ffffffff8109709e>] ? __create_workqueue_key+0x3e/0x1d0
>  [<ffffffff8109709e>] ? __create_workqueue_key+0x3e/0x1d0
>  [<ffffffffa00c101c>] ? fnic_probe+0x977/0x11aa [fnic]
>  [<ffffffffa00c1048>] ? fnic_probe+0x9a3/0x11aa [fnic]
>  [<ffffffff81096f00>] ? do_work_for_cpu+0x0/0x30
>  [<ffffffff812c6da7>] ? local_pci_probe+0x17/0x20
>  [<ffffffff81096f18>] ? do_work_for_cpu+0x18/0x30
>  [<ffffffff8109cdc6>] ? kthread+0x96/0xa0
>  [<ffffffff8100c1ca>] ? child_rip+0xa/0x20
>  [<ffffffff81550f80>] ? _spin_unlock_irq+0x30/0x40
>  [<ffffffff8100bb10>] ? restore_args+0x0/0x30
>  [<ffffffff8109cd30>] ? kthread+0x0/0xa0
>  [<ffffffff8100c1c0>] ? child_rip+0x0/0x20

The problem is in this hunk of "FIP VLAN Discovery Feature Support"
(d3c995f1dc)

create_singlethreaded_workqueue cannot be called with irqs disabled

@@ -620,7 +634,29 @@ static int __devinit fnic_probe(struct pci_dev
*pdev,
        vnic_dev_packet_filter(fnic->vdev, 1, 1, 0, 0, 0);
        vnic_dev_add_addr(fnic->vdev, FIP_ALL_ENODE_MACS);
        vnic_dev_add_addr(fnic->vdev, fnic->ctlr.ctl_src_addr);
+       fnic->set_vlan = fnic_set_vlan;
        fcoe_ctlr_init(&fnic->ctlr, FIP_MODE_AUTO);
+       setup_timer(&fnic->fip_timer, fnic_fip_notify_timer,
+                           (unsigned long)fnic);
+       spin_lock_init(&fnic->vlans_lock);
+       INIT_WORK(&fnic->fip_frame_work, fnic_handle_fip_frame);
+       INIT_WORK(&fnic->event_work, fnic_handle_event);
+       skb_queue_head_init(&fnic->fip_frame_queue);
+       spin_lock_irqsave(&fnic_list_lock, flags);
+       if (!fnic_fip_queue) {
+           fnic_fip_queue =
+               create_singlethread_workqueue("fnic_fip_q");
+           if (!fnic_fip_queue) {
+               spin_unlock_irqrestore(&fnic_list_lock, flags);
+               printk(KERN_ERR PFX "fnic FIP work queue "
+                        "create failed\n");
+               err = -ENOMEM;
+               goto err_out_free_max_pool;
+           }
+       }
+       spin_unlock_irqrestore(&fnic_list_lock, flags);
+       INIT_LIST_HEAD(&fnic->evlist);
+       INIT_LIST_HEAD(&fnic->vlans);
    } else {
        shost_printk(KERN_INFO, fnic->lport->host,
                 "firmware uses non-FIP mode\n");

The attempts to make fnic_fip_queue a single instance for the driver
while it's being created in probe look awkward anyway, why is this not
created in fnic_init_module like the event workqueue?

Signed-off-by: Chris Leech <cleech@redhat.com>
Tested-by: Anantha Tungarakodi <atungara@cisco.com>
Acked-by: Hiral Patel <hiralpat@cisco.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2013-08-02 13:16:38 -07:00
..
cq_desc.h
cq_enet_desc.h
cq_exch_desc.h
fcpio.h
fnic_attrs.c
fnic_debugfs.c fnic: switch to fixed_size_llseek() 2013-06-29 12:57:31 +04:00
fnic_fcs.c [SCSI] fnic: Kernel panic due to FIP mode misconfiguration 2013-05-02 07:32:23 -07:00
fnic_fip.h [SCSI] fnic: FIP VLAN Discovery Feature Support 2013-05-02 07:30:40 -07:00
fnic_io.h [SCSI] fnic: New debug flags and debug log messages 2013-02-22 17:31:09 +00:00
fnic_isr.c [SCSI] fnic: Process all cq entries per ISR 2009-12-04 12:00:35 -06:00
fnic_main.c [SCSI] fnic: BUG: sleeping function called from invalid context during probe 2013-08-02 13:16:38 -07:00
fnic_res.c [SCSI] fnic: Add FIP support to the fnic driver 2009-12-04 12:01:19 -06:00
fnic_res.h [SCSI] fnic: Add FIP support to the fnic driver 2009-12-04 12:01:19 -06:00
fnic_scsi.c [SCSI] fnic: potential dead lock in fnic_is_abts_pending() 2013-06-26 17:41:44 -07:00
fnic_trace.c [SCSI] fnic: Fnic Trace Utility 2013-02-22 17:32:07 +00:00
fnic_trace.h [SCSI] fnic: Fnic Trace Utility 2013-02-22 17:32:07 +00:00
fnic.h [SCSI] fnic: BUG: sleeping function called from invalid context during probe 2013-08-02 13:16:38 -07:00
Makefile [SCSI] fnic: Fnic Trace Utility 2013-02-22 17:32:07 +00:00
rq_enet_desc.h
vnic_cq_copy.h
vnic_cq.c
vnic_cq.h
vnic_dev.c [SCSI] fnic: FIP VLAN Discovery Feature Support 2013-05-02 07:30:40 -07:00
vnic_dev.h [SCSI] fnic: FIP VLAN Discovery Feature Support 2013-05-02 07:30:40 -07:00
vnic_devcmd.h [SCSI] fnic: FIP VLAN Discovery Feature Support 2013-05-02 07:30:40 -07:00
vnic_intr.c
vnic_intr.h
vnic_nic.h
vnic_resource.h
vnic_rq.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
vnic_rq.h
vnic_scsi.h [SCSI] fnic: Add FIP support to the fnic driver 2009-12-04 12:01:19 -06:00
vnic_stats.h
vnic_wq_copy.c
vnic_wq_copy.h
vnic_wq.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
vnic_wq.h
wq_enet_desc.h