linux/drivers/gpu/drm/omapdrm
Tomi Valkeinen 393a949f51 drm/omap: fix omap_gem_put_paddr() error handling
If tiler_unpin() call in omap_gem_put_paddr() fails,
omap_gem_put_paddr() will immediately stop processing and return an
error.

This patch remoes that error checking, and also removes
omap_gem_put_paddr()'s return value, because:

 * The caller of omap_gem_put_paddr() can do nothing if an error
   happens, so it's pointless to return an error value

 * If tiler_unpin() fails, the GEM object will possibly be left in an
   undefined state, where the DMM mapping may have been removed, but the
   GEM object still thinks everything is as it should be, leading to
   crashes later.

 * There's no point in returning an error from a "free" call, as the
   caller can do nothing about it. So it's better to clean up as much as
   possible.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
2015-07-02 15:58:06 +03:00
..
Kconfig drm: Add separate Kconfig option for fbdev helpers 2013-10-11 23:36:58 +02:00
Makefile drm/omap: kill omap_gem_helpers.c 2013-08-19 10:36:16 +10:00
omap_connector.c drm: omapdrm: Switch connector DPMS to atomic helpers 2015-06-12 22:52:48 +03:00
omap_crtc.c drm: omapdrm: new vblank and event handling 2015-06-12 23:30:47 +03:00
omap_debugfs.c drm: omapdrm: Clean up #include's 2015-06-12 22:52:46 +03:00
omap_dmm_priv.h drm/omap: fix race conditon in DMM 2015-03-24 13:50:59 +02:00
omap_dmm_tiler.c drm/omap: increase DMM transaction timeout 2015-07-02 15:58:06 +03:00
omap_dmm_tiler.h drm/omap: fix TILER on OMAP5 2015-03-24 13:50:55 +02:00
omap_drv.c drm: omapdrm: new vblank and event handling 2015-06-12 23:30:47 +03:00
omap_drv.h drm/omap: fix omap_gem_put_paddr() error handling 2015-07-02 15:58:06 +03:00
omap_encoder.c drm: omapdrm: Move encoder setup to encoder operations 2015-06-12 22:52:50 +03:00
omap_fb.c drm/omap: fix omap_framebuffer_unpin() error handling 2015-07-02 15:58:06 +03:00
omap_fbdev.c drm: omapdrm: Clean up #include's 2015-06-12 22:52:46 +03:00
omap_gem_dmabuf.c drm: omapdrm: Clean up #include's 2015-06-12 22:52:46 +03:00
omap_gem.c drm/omap: fix omap_gem_put_paddr() error handling 2015-07-02 15:58:06 +03:00
omap_irq.c drm: omapdrm: Turn vblank on/off when enabling/disabling CRTC 2015-06-12 22:52:46 +03:00
omap_plane.c drm/omap: check that plane is inside crtc 2015-07-02 15:57:58 +03:00
tcm-sita.c
tcm-sita.h
tcm.h
TODO