Leo Yan 3220fb8d5e perf parse: Copy string to perf_evsel_config_term ... perf with CoreSight fails to record trace data with command: perf record -e cs_etm/@tmc_etr0/u --per-thread ls failed to set sink "" on event cs_etm/@tmc_etr0/u with 21 (Is a directory)/perf/ This failure is root caused with the commit 1dc925568f ("perf parse: Add a deep delete for parse event terms"). The log shows, cs_etm fails to parse the sink attribution; cs_etm event relies on the event configuration to pass sink name, but the event specific configuration data cannot be passed properly with flow: get_config_terms() ADD_CONFIG_TERM(DRV_CFG, term->val.str); __t->val.str = term->val.str; `> __t->val.str is assigned to term->val.str; parse_events_terms__purge() parse_events_term__delete() zfree(&term->val.str); `> term->val.str is freed and assigned to NULL pointer; cs_etm_set_sink_attr() sink = __t->val.str; `> sink string has been freed. To fix this issue, in the function get_config_terms(), this patch changes to use strdup() for allocation a new duplicate string rather than directly assignment string pointer. This patch addes a new field 'free_str' in the data structure perf_evsel_config_term; 'free_str' is set to true when the union is used as a string pointer; thus it can tell perf_evsel__free_config_terms() to free the string. Fixes: 1dc925568f ("perf parse: Add a deep delete for parse event terms") Suggested-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Leo Yan <leo.yan@linaro.org> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Mike Leach <mike.leach@linaro.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Suzuki Poulouse <suzuki.poulose@arm.com> Cc: linux-arm-kernel@lists.infradead.org Link: http://lore.kernel.org/lkml/20200117055251.24058-2-leo.yan@linaro.org [ Use zfree() in perf_evsel__free_config_terms ] Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> :# modified: tools/perf/util/evsel_config.h		2020-01-30 11:55:02 +01:00
..
accounting
arch	tools arch x86: Sync asm/cpufeatures.h with the kernel sources	2019-12-02 15:20:05 -03:00
bpf	bpftool: Fix printing incorrect pointer in btf_dump_ptr	2020-01-11 19:08:21 -08:00
build	perf/ui/gtk: Fix gtk2 build	2020-01-14 12:40:33 -03:00
cgroup
debugging
firewire
firmware
gpio	tools: gpio: Correctly add make dependencies for gpio_utils	2019-11-13 13:46:04 +01:00
hv	tools: hv: add vmbus testing tool	2019-11-21 20:10:44 -05:00
iio	tools: iio: Correctly add make dependency for iio_utils	2019-11-10 17:11:06 +00:00
include	tools lib: Fix builds when glibc contains strlcpy()	2020-01-06 11:46:10 -03:00
io_uring
kvm/kvm_stat
laptop
leds
lib	perf/core improvements and fixes:	2020-01-20 08:44:04 +01:00
memory-model
nfsd
objtool	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-11-26 15:04:47 -08:00
pci	tools: PCI: Fix fd leakage	2019-10-29 12:04:18 +00:00
pcmcia
perf	perf parse: Copy string to perf_evsel_config_term	2020-01-30 11:55:02 +01:00
power	platform-drivers-x86 for v5.5-1	2019-12-01 18:24:25 -08:00
scripts
spi
testing	selftests: mlxsw: qos_mc_aware: Fix mausezahn invocation	2020-01-15 04:16:30 -08:00
thermal/tmon
time
usb	usbip: tools: fix fd leakage in the function of read_attr_usbip_status	2019-11-07 11:25:01 +01:00
virtio
vm
wmi
Makefile