24c478ead0
So far, the drm_format_plane_cpp function was operating on the format's fourcc and was doing a lookup to retrieve the drm_format_info structure and return the cpp. However, this is inefficient since in most cases, we will have the drm_format_info pointer already available so we shouldn't have to perform a new lookup. Some drm_fourcc functions also already operate on the drm_format_info pointer for that reason, so the API is quite inconsistent there. Let's follow the latter pattern and remove the extra lookup while being a bit more consistent. In order to be extra consistent, also rename that function to drm_format_info_plane_cpp and to a static function in the header to match the current policy. Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Link: https://patchwork.freedesktop.org/patch/msgid/32aa13e53dbc98a90207fd290aa8e79f785fb11e.1558002671.git-series.maxime.ripard@bootlin.com
128 lines
3.0 KiB
C
128 lines
3.0 KiB
C
/*
|
|
* Copyright (c) 2015 MediaTek Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/drm_modeset_helper.h>
|
|
#include <drm/drm_fb_helper.h>
|
|
#include <drm/drm_gem.h>
|
|
#include <drm/drm_gem_framebuffer_helper.h>
|
|
#include <linux/dma-buf.h>
|
|
#include <linux/reservation.h>
|
|
|
|
#include "mtk_drm_drv.h"
|
|
#include "mtk_drm_fb.h"
|
|
#include "mtk_drm_gem.h"
|
|
|
|
static const struct drm_framebuffer_funcs mtk_drm_fb_funcs = {
|
|
.create_handle = drm_gem_fb_create_handle,
|
|
.destroy = drm_gem_fb_destroy,
|
|
};
|
|
|
|
static struct drm_framebuffer *mtk_drm_framebuffer_init(struct drm_device *dev,
|
|
const struct drm_mode_fb_cmd2 *mode,
|
|
struct drm_gem_object *obj)
|
|
{
|
|
const struct drm_format_info *info = drm_get_format_info(dev, mode);
|
|
struct drm_framebuffer *fb;
|
|
int ret;
|
|
|
|
if (info->num_planes != 1)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
fb = kzalloc(sizeof(*fb), GFP_KERNEL);
|
|
if (!fb)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
drm_helper_mode_fill_fb_struct(dev, fb, mode);
|
|
|
|
fb->obj[0] = obj;
|
|
|
|
ret = drm_framebuffer_init(dev, fb, &mtk_drm_fb_funcs);
|
|
if (ret) {
|
|
DRM_ERROR("failed to initialize framebuffer\n");
|
|
kfree(fb);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
return fb;
|
|
}
|
|
|
|
/*
|
|
* Wait for any exclusive fence in fb's gem object's reservation object.
|
|
*
|
|
* Returns -ERESTARTSYS if interrupted, else 0.
|
|
*/
|
|
int mtk_fb_wait(struct drm_framebuffer *fb)
|
|
{
|
|
struct drm_gem_object *gem;
|
|
struct reservation_object *resv;
|
|
long ret;
|
|
|
|
if (!fb)
|
|
return 0;
|
|
|
|
gem = fb->obj[0];
|
|
if (!gem || !gem->dma_buf || !gem->dma_buf->resv)
|
|
return 0;
|
|
|
|
resv = gem->dma_buf->resv;
|
|
ret = reservation_object_wait_timeout_rcu(resv, false, true,
|
|
MAX_SCHEDULE_TIMEOUT);
|
|
/* MAX_SCHEDULE_TIMEOUT on success, -ERESTARTSYS if interrupted */
|
|
if (WARN_ON(ret < 0))
|
|
return ret;
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct drm_framebuffer *mtk_drm_mode_fb_create(struct drm_device *dev,
|
|
struct drm_file *file,
|
|
const struct drm_mode_fb_cmd2 *cmd)
|
|
{
|
|
const struct drm_format_info *info = drm_get_format_info(dev, cmd);
|
|
struct drm_framebuffer *fb;
|
|
struct drm_gem_object *gem;
|
|
unsigned int width = cmd->width;
|
|
unsigned int height = cmd->height;
|
|
unsigned int size, bpp;
|
|
int ret;
|
|
|
|
if (info->num_planes != 1)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
gem = drm_gem_object_lookup(file, cmd->handles[0]);
|
|
if (!gem)
|
|
return ERR_PTR(-ENOENT);
|
|
|
|
bpp = drm_format_info_plane_cpp(info, 0);
|
|
size = (height - 1) * cmd->pitches[0] + width * bpp;
|
|
size += cmd->offsets[0];
|
|
|
|
if (gem->size < size) {
|
|
ret = -EINVAL;
|
|
goto unreference;
|
|
}
|
|
|
|
fb = mtk_drm_framebuffer_init(dev, cmd, gem);
|
|
if (IS_ERR(fb)) {
|
|
ret = PTR_ERR(fb);
|
|
goto unreference;
|
|
}
|
|
|
|
return fb;
|
|
|
|
unreference:
|
|
drm_gem_object_put_unlocked(gem);
|
|
return ERR_PTR(ret);
|
|
}
|