linux/arch
Peter Zijlstra 20273941f2 mm: fix race in kunmap_atomic()
Christoph reported a nice splat which illustrated a race in the new stack
based kmap_atomic implementation.

The problem is that we pop our stack slot before we're completely done
resetting its state -- in particular clearing the PTE (sometimes that's
CONFIG_DEBUG_HIGHMEM).  If an interrupt happens before we actually clear
the PTE used for the last slot, that interrupt can reuse the slot in a
dirty state, which triggers a BUG in kmap_atomic().

Fix this by introducing kmap_atomic_idx() which reports the current slot
index without actually releasing it and use that to find the PTE and delay
the _pop() until after we're completely done.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Reported-by: Christoph Hellwig <hch@infradead.org>
Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-10-27 18:03:05 -07:00
..
alpha alpha: use single HAE window on T2 core logic (gamma, sable) 2010-10-26 16:52:12 -07:00
arm mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
avr32 mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
blackfin m68k{nommu}/blackfin : remove old assembler-only flags bit definitions 2010-10-26 16:52:12 -07:00
cris mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
frv mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
h8300 Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial 2010-10-24 13:41:39 -07:00
ia64 mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
m32r mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
m68k m68k{nommu}/blackfin : remove old assembler-only flags bit definitions 2010-10-26 16:52:12 -07:00
m68knommu Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu 2010-10-25 07:44:27 -07:00
microblaze mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
mips mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
mn10300 mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
parisc mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
powerpc mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
s390 mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
score mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
sh mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
sparc mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
tile mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
um um: migrate from __do_IRQ() to generic_handle_irq() 2010-10-26 16:52:12 -07:00
x86 mm: fix race in kunmap_atomic() 2010-10-27 18:03:05 -07:00
xtensa mm: remove pte_*map_nested() 2010-10-26 16:52:08 -07:00
.gitignore
Kconfig Merge branch 'tip/perf/core' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace into perf/core 2010-09-24 09:12:05 +02:00