linux/drivers/net/ethernet/qlogic
Nathan Chancellor 1c492a9d55 qed: Avoid constant logical operation warning in qed_vf_pf_acquire
Clang warns when a constant is used in a boolean context as it thinks a
bitwise operation may have been intended.

drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: warning: use of logical
'&&' with constant operand [-Wconstant-logical-operand]
        if (!p_iov->b_pre_fp_hsi &&
                                 ^
drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: use '&' for a
bitwise operation
        if (!p_iov->b_pre_fp_hsi &&
                                 ^~
                                 &
drivers/net/ethernet/qlogic/qed/qed_vf.c:415:27: note: remove constant
to silence this warning
        if (!p_iov->b_pre_fp_hsi &&
                                ~^~
1 warning generated.

This has been here since commit 1fe614d10f ("qed: Relax VF firmware
requirements") and I am not entirely sure why since 0 isn't a special
case. Just remove the statement causing Clang to warn since it isn't
required.

Link: https://github.com/ClangBuiltLinux/linux/issues/126
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-09-26 20:23:04 -07:00
..
netxen netxen_nic: Mark expected switch fall-throughs 2018-08-07 17:54:20 -07:00
qed qed: Avoid constant logical operation warning in qed_vf_pf_acquire 2018-09-26 20:23:04 -07:00
qede net_sched: remove list_head from tc_action 2018-08-21 12:45:44 -07:00
qlcnic ethernet/qlogic: remove unused array msi_tgt_status 2018-08-09 14:16:51 -07:00
qlge qlge: Fix netdev features configuration. 2018-08-25 17:37:38 -07:00
Kconfig qed*: Utilize FW 8.33.1.0 2018-01-02 13:59:16 -05:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qla3xxx.c net: qla3xxx: Eliminate duplicate barriers on weakly-ordered archs 2018-03-26 12:47:55 -04:00
qla3xxx.h