81895a65ec
Rather than incurring a division or requesting too many random bytes for
the given range, use the prandom_u32_max() function, which only takes
the minimum required bytes from the RNG and avoids divisions. This was
done mechanically with this coccinelle script:
@basic@
expression E;
type T;
identifier get_random_u32 =~ "get_random_int|prandom_u32|get_random_u32";
typedef u64;
@@
(
- ((T)get_random_u32() % (E))
+ prandom_u32_max(E)
|
- ((T)get_random_u32() & ((E) - 1))
+ prandom_u32_max(E * XXX_MAKE_SURE_E_IS_POW2)
|
- ((u64)(E) * get_random_u32() >> 32)
+ prandom_u32_max(E)
|
- ((T)get_random_u32() & ~PAGE_MASK)
+ prandom_u32_max(PAGE_SIZE)
)
@multi_line@
identifier get_random_u32 =~ "get_random_int|prandom_u32|get_random_u32";
identifier RAND;
expression E;
@@
- RAND = get_random_u32();
... when != RAND
- RAND %= (E);
+ RAND = prandom_u32_max(E);
// Find a potential literal
@literal_mask@
expression LITERAL;
type T;
identifier get_random_u32 =~ "get_random_int|prandom_u32|get_random_u32";
position p;
@@
((T)get_random_u32()@p & (LITERAL))
// Add one to the literal.
@script:python add_one@
literal << literal_mask.LITERAL;
RESULT;
@@
value = None
if literal.startswith('0x'):
value = int(literal, 16)
elif literal[0] in '123456789':
value = int(literal, 10)
if value is None:
print("I don't know how to handle %s" % (literal))
cocci.include_match(False)
elif value == 2**32 - 1 or value == 2**31 - 1 or value == 2**24 - 1 or value == 2**16 - 1 or value == 2**8 - 1:
print("Skipping 0x%x for cleanup elsewhere" % (value))
cocci.include_match(False)
elif value & (value + 1) != 0:
print("Skipping 0x%x because it's not a power of two minus one" % (value))
cocci.include_match(False)
elif literal.startswith('0x'):
coccinelle.RESULT = cocci.make_expr("0x%x" % (value + 1))
else:
coccinelle.RESULT = cocci.make_expr("%d" % (value + 1))
// Replace the literal mask with the calculated result.
@plus_one@
expression literal_mask.LITERAL;
position literal_mask.p;
expression add_one.RESULT;
identifier FUNC;
@@
- (FUNC()@p & (LITERAL))
+ prandom_u32_max(RESULT)
@collapse_ret@
type T;
identifier VAR;
expression E;
@@
{
- T VAR;
- VAR = (E);
- return VAR;
+ return E;
}
@drop_var@
type T;
identifier VAR;
@@
{
- T VAR;
... when != VAR
}
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Yury Norov <yury.norov@gmail.com>
Reviewed-by: KP Singh <kpsingh@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz> # for ext4 and sbitmap
Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com> # for drbd
Acked-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Heiko Carstens <hca@linux.ibm.com> # for s390
Acked-by: Ulf Hansson <ulf.hansson@linaro.org> # for mmc
Acked-by: Darrick J. Wong <djwong@kernel.org> # for xfs
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
130 lines
4.0 KiB
C
130 lines
4.0 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (c) International Business Machines Corp., 2006
|
|
*
|
|
* Author: Artem Bityutskiy (Битюцкий Артём)
|
|
*/
|
|
|
|
#ifndef __UBI_DEBUG_H__
|
|
#define __UBI_DEBUG_H__
|
|
|
|
void ubi_dump_flash(struct ubi_device *ubi, int pnum, int offset, int len);
|
|
void ubi_dump_ec_hdr(const struct ubi_ec_hdr *ec_hdr);
|
|
void ubi_dump_vid_hdr(const struct ubi_vid_hdr *vid_hdr);
|
|
|
|
#include <linux/random.h>
|
|
|
|
#define ubi_assert(expr) do { \
|
|
if (unlikely(!(expr))) { \
|
|
pr_crit("UBI assert failed in %s at %u (pid %d)\n", \
|
|
__func__, __LINE__, current->pid); \
|
|
dump_stack(); \
|
|
} \
|
|
} while (0)
|
|
|
|
#define ubi_dbg_print_hex_dump(l, ps, pt, r, g, b, len, a) \
|
|
print_hex_dump(l, ps, pt, r, g, b, len, a)
|
|
|
|
#define ubi_dbg_msg(type, fmt, ...) \
|
|
pr_debug("UBI DBG " type " (pid %d): " fmt "\n", current->pid, \
|
|
##__VA_ARGS__)
|
|
|
|
/* General debugging messages */
|
|
#define dbg_gen(fmt, ...) ubi_dbg_msg("gen", fmt, ##__VA_ARGS__)
|
|
/* Messages from the eraseblock association sub-system */
|
|
#define dbg_eba(fmt, ...) ubi_dbg_msg("eba", fmt, ##__VA_ARGS__)
|
|
/* Messages from the wear-leveling sub-system */
|
|
#define dbg_wl(fmt, ...) ubi_dbg_msg("wl", fmt, ##__VA_ARGS__)
|
|
/* Messages from the input/output sub-system */
|
|
#define dbg_io(fmt, ...) ubi_dbg_msg("io", fmt, ##__VA_ARGS__)
|
|
/* Initialization and build messages */
|
|
#define dbg_bld(fmt, ...) ubi_dbg_msg("bld", fmt, ##__VA_ARGS__)
|
|
|
|
void ubi_dump_vol_info(const struct ubi_volume *vol);
|
|
void ubi_dump_vtbl_record(const struct ubi_vtbl_record *r, int idx);
|
|
void ubi_dump_av(const struct ubi_ainf_volume *av);
|
|
void ubi_dump_aeb(const struct ubi_ainf_peb *aeb, int type);
|
|
void ubi_dump_mkvol_req(const struct ubi_mkvol_req *req);
|
|
int ubi_self_check_all_ff(struct ubi_device *ubi, int pnum, int offset,
|
|
int len);
|
|
int ubi_debugfs_init(void);
|
|
void ubi_debugfs_exit(void);
|
|
int ubi_debugfs_init_dev(struct ubi_device *ubi);
|
|
void ubi_debugfs_exit_dev(struct ubi_device *ubi);
|
|
|
|
/**
|
|
* ubi_dbg_is_bgt_disabled - if the background thread is disabled.
|
|
* @ubi: UBI device description object
|
|
*
|
|
* Returns non-zero if the UBI background thread is disabled for testing
|
|
* purposes.
|
|
*/
|
|
static inline int ubi_dbg_is_bgt_disabled(const struct ubi_device *ubi)
|
|
{
|
|
return ubi->dbg.disable_bgt;
|
|
}
|
|
|
|
/**
|
|
* ubi_dbg_is_bitflip - if it is time to emulate a bit-flip.
|
|
* @ubi: UBI device description object
|
|
*
|
|
* Returns non-zero if a bit-flip should be emulated, otherwise returns zero.
|
|
*/
|
|
static inline int ubi_dbg_is_bitflip(const struct ubi_device *ubi)
|
|
{
|
|
if (ubi->dbg.emulate_bitflips)
|
|
return !prandom_u32_max(200);
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* ubi_dbg_is_write_failure - if it is time to emulate a write failure.
|
|
* @ubi: UBI device description object
|
|
*
|
|
* Returns non-zero if a write failure should be emulated, otherwise returns
|
|
* zero.
|
|
*/
|
|
static inline int ubi_dbg_is_write_failure(const struct ubi_device *ubi)
|
|
{
|
|
if (ubi->dbg.emulate_io_failures)
|
|
return !prandom_u32_max(500);
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* ubi_dbg_is_erase_failure - if its time to emulate an erase failure.
|
|
* @ubi: UBI device description object
|
|
*
|
|
* Returns non-zero if an erase failure should be emulated, otherwise returns
|
|
* zero.
|
|
*/
|
|
static inline int ubi_dbg_is_erase_failure(const struct ubi_device *ubi)
|
|
{
|
|
if (ubi->dbg.emulate_io_failures)
|
|
return !prandom_u32_max(400);
|
|
return 0;
|
|
}
|
|
|
|
static inline int ubi_dbg_chk_io(const struct ubi_device *ubi)
|
|
{
|
|
return ubi->dbg.chk_io;
|
|
}
|
|
|
|
static inline int ubi_dbg_chk_gen(const struct ubi_device *ubi)
|
|
{
|
|
return ubi->dbg.chk_gen;
|
|
}
|
|
|
|
static inline int ubi_dbg_chk_fastmap(const struct ubi_device *ubi)
|
|
{
|
|
return ubi->dbg.chk_fastmap;
|
|
}
|
|
|
|
static inline void ubi_enable_dbg_chk_fastmap(struct ubi_device *ubi)
|
|
{
|
|
ubi->dbg.chk_fastmap = 1;
|
|
}
|
|
|
|
int ubi_dbg_power_cut(struct ubi_device *ubi, int caller);
|
|
#endif /* !__UBI_DEBUG_H__ */
|