Dan Williams 4d66e5e9b6 block: fix ext_dev_lock lockdep report ... ================================= [ INFO: inconsistent lock state ] 4.1.0-rc7+ #217 Tainted: G O --------------------------------- inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage. swapper/6/0 [HC0[0]:SC1[1]:HE1:SE0] takes: (ext_devt_lock){+.?...}, at: [<ffffffff8143a60c>] blk_free_devt+0x3c/0x70 {SOFTIRQ-ON-W} state was registered at: [<ffffffff810bf6b1>] __lock_acquire+0x461/0x1e70 [<ffffffff810c1947>] lock_acquire+0xb7/0x290 [<ffffffff818ac3a8>] _raw_spin_lock+0x38/0x50 [<ffffffff8143a07d>] blk_alloc_devt+0x6d/0xd0 <-- take the lock in process context [..] [<ffffffff810bf64e>] __lock_acquire+0x3fe/0x1e70 [<ffffffff810c00ad>] ? __lock_acquire+0xe5d/0x1e70 [<ffffffff810c1947>] lock_acquire+0xb7/0x290 [<ffffffff8143a60c>] ? blk_free_devt+0x3c/0x70 [<ffffffff818ac3a8>] _raw_spin_lock+0x38/0x50 [<ffffffff8143a60c>] ? blk_free_devt+0x3c/0x70 [<ffffffff8143a60c>] blk_free_devt+0x3c/0x70 <-- take the lock in softirq [<ffffffff8143bfec>] part_release+0x1c/0x50 [<ffffffff8158edf6>] device_release+0x36/0xb0 [<ffffffff8145ac2b>] kobject_cleanup+0x7b/0x1a0 [<ffffffff8145aad0>] kobject_put+0x30/0x70 [<ffffffff8158f147>] put_device+0x17/0x20 [<ffffffff8143c29c>] delete_partition_rcu_cb+0x16c/0x180 [<ffffffff8143c130>] ? read_dev_sector+0xa0/0xa0 [<ffffffff810e0e0f>] rcu_process_callbacks+0x2ff/0xa90 [<ffffffff810e0dcf>] ? rcu_process_callbacks+0x2bf/0xa90 [<ffffffff81067e2e>] __do_softirq+0xde/0x600 Neil sees this in his tests and it also triggers on pmem driver unbind for the libnvdimm tests. This fix is on top of an initial fix by Keith for incorrect usage of mutex_lock() in this path: 2da78092dd "block: Fix dev_t minor allocation lifetime". Both this and 2da78092dd are candidates for -stable. Fixes: 2da78092dd ("block: Fix dev_t minor allocation lifetime") Cc: <stable@vger.kernel.org> Cc: Keith Busch <keith.busch@intel.com> Reported-by: NeilBrown <neilb@suse.de> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Jens Axboe <axboe@fb.com>		2015-06-11 09:01:40 -06:00
..
partitions	Merge branch 'for-3.20/core' of git://git.kernel.dk/linux-block	2015-02-12 14:13:23 -08:00
bio-integrity.c	block: fix regression where bio_integrity_process uses wrong bio_vec iterator	2014-12-02 08:15:21 -07:00
bio.c	block: rewrite and split __bio_copy_iov()	2015-02-05 09:30:44 -07:00
blk-cgroup.c	blkcg: remove blkcg->id	2014-09-08 09:55:37 -06:00
blk-cgroup.h	blkcg: remove blkcg->id	2014-09-08 09:55:37 -06:00
blk-core.c	block: remove export for blk_queue_bio	2015-05-12 17:21:22 -04:00
blk-exec.c	blk-mq: avoid infinite recursion with the FUA flag	2014-09-22 11:55:19 -06:00
blk-flush.c	blk-mq: support per-distpatch_queue flush machinery	2014-09-25 15:22:45 -06:00
blk-integrity.c	block: Don't merge requests if integrity flags differ	2014-09-27 09:14:57 -06:00
blk-ioc.c	block: Substitute rcu_access_pointer() for rcu_dereference_raw()	2014-02-18 12:21:26 -08:00
blk-iopoll.c	Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next	2014-06-03 12:57:53 -07:00
blk-lib.c	block: Quiesce zeroout wrapper	2015-02-05 10:14:54 -07:00
blk-map.c	blk_rq_map_user(): use import_single_range()	2015-04-11 22:27:13 -04:00
blk-merge.c	Fix bug in blk_rq_merge_ok	2015-03-20 08:50:41 -06:00
blk-mq-cpu.c	blk-mq: add file comments and update copyright notices	2014-05-28 10:15:41 -06:00
blk-mq-cpumap.c	blk-mq: Use all available hardware queues	2014-12-09 09:08:21 -07:00
blk-mq-sysfs.c	blk-mq: add blk_mq_init_allocated_queue and export blk_mq_register_disk	2015-03-13 08:26:53 -06:00
blk-mq-tag.c	blkmq: Fix NULL pointer deref when all reserved tags in	2015-03-18 17:06:18 -06:00
blk-mq-tag.h	blk-mq: add tag allocation policy	2015-01-23 14:18:00 -07:00
blk-mq.c	blk-mq: free hctx->ctxs in queue's release handler	2015-06-09 15:32:38 -06:00
blk-mq.h	blk-mq: release mq's kobjects in blk_release_queue()	2015-01-29 08:30:51 -08:00
blk-settings.c	block: fix blk_stack_limits() regression due to lcm() change	2015-03-31 09:45:50 -06:00
blk-softirq.c	block: fix regression with block enabled tagging	2014-04-09 21:54:06 -06:00
blk-sysfs.c	block: destroy bdi before blockdev is unregistered.	2015-04-27 10:27:20 -06:00
blk-tag.c	block: support different tag allocation policy	2015-01-23 14:15:46 -07:00
blk-throttle.c	blk-throttle: check stats_cpu before reading it from sysfs	2015-02-20 22:11:58 -08:00
blk-timeout.c	blk-mq: Allow requests to never expire	2015-01-08 08:59:01 -07:00
blk.h	blk-mq: support per-distpatch_queue flush machinery	2014-09-25 15:22:45 -06:00
bounce.c	block:bounce: fix call inc_|dec_zone_page_state on different pages confuse value of NR_BOUNCE	2015-04-27 09:24:07 -06:00
bsg-lib.c
bsg.c	block: Simplify bsg complete all	2015-02-04 09:57:52 -07:00
cfq-iosched.c	cfq-iosched: handle failure of cfq group allocation	2015-02-09 10:22:39 -07:00
cmdline-parser.c	block: remove unrelated header files and export symbol	2014-01-21 20:18:26 -08:00
compat_ioctl.c	block, bdi: an active gendisk always has a request_queue associated with it	2014-09-08 10:00:35 -06:00
deadline-iosched.c	block: Stop abusing csd.list for fifo_time	2014-02-24 14:46:32 -08:00
elevator.c	elevator: fix double release of elevator module	2015-04-23 10:47:44 -06:00
genhd.c	block: fix ext_dev_lock lockdep report	2015-06-11 09:01:40 -06:00
ioctl.c	block: Add discard flag to blkdev_issue_zeroout() function	2015-01-21 10:41:46 -07:00
ioprio.c	block: Fix computation of merged request priority	2014-10-31 08:30:43 -06:00
Kconfig	block: Add T10 Protection Information functions	2014-09-27 09:14:59 -06:00
Kconfig.iosched
Makefile	block: Add T10 Protection Information functions	2014-09-27 09:14:59 -06:00
noop-iosched.c
partition-generic.c	block: Fix dev_t minor allocation lifetime	2014-09-03 15:01:02 -06:00
scsi_ioctl.c	sg_io(): use import_iovec()	2015-04-11 22:27:13 -04:00
t10-pi.c	block: Add T10 Protection Information functions	2014-09-27 09:14:59 -06:00