forked from Minki/linux
443121b3eb
lib/test_fpu.c:66:0-23: WARNING: test_fpu_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.
Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
In order to protect against file removal races, debugfs files created
via debugfs_create_file() now get wrapped by a struct file_operations
at their opening.
If the original struct file_operations are known to be safe against
removal races by themselves already, the proxy creation may be bypassed
by creating the files through debugfs_create_file_unsafe().
In order to help debugfs users who use the common
DEFINE_SIMPLE_ATTRIBUTE() + debugfs_create_file() idiom to
transition to removal safe struct file_operations, the helper macro
DEFINE_DEBUGFS_ATTRIBUTE() has been introduced.
Thus, the preferred strategy is to use
DEFINE_DEBUGFS_ATTRIBUTE() + debugfs_create_file_unsafe()
now.
Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Fixes: 4185b3b927 ("selftests/fpu: Add an FPU selftest")
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/alpine.DEB.2.22.394.2010251117180.2714@hadrien
90 lines
2.0 KiB
C
90 lines
2.0 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Test cases for using floating point operations inside a kernel module.
|
|
*
|
|
* This tests kernel_fpu_begin() and kernel_fpu_end() functions, especially
|
|
* when userland has modified the floating point control registers. The kernel
|
|
* state might depend on the state set by the userland thread that was active
|
|
* before a syscall.
|
|
*
|
|
* To facilitate the test, this module registers file
|
|
* /sys/kernel/debug/selftest_helpers/test_fpu, which when read causes a
|
|
* sequence of floating point operations. If the operations fail, either the
|
|
* read returns error status or the kernel crashes.
|
|
* If the operations succeed, the read returns "1\n".
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/debugfs.h>
|
|
#include <asm/fpu/api.h>
|
|
|
|
static int test_fpu(void)
|
|
{
|
|
/*
|
|
* This sequence of operations tests that rounding mode is
|
|
* to nearest and that denormal numbers are supported.
|
|
* Volatile variables are used to avoid compiler optimizing
|
|
* the calculations away.
|
|
*/
|
|
volatile double a, b, c, d, e, f, g;
|
|
|
|
a = 4.0;
|
|
b = 1e-15;
|
|
c = 1e-310;
|
|
|
|
/* Sets precision flag */
|
|
d = a + b;
|
|
|
|
/* Result depends on rounding mode */
|
|
e = a + b / 2;
|
|
|
|
/* Denormal and very large values */
|
|
f = b / c;
|
|
|
|
/* Depends on denormal support */
|
|
g = a + c * f;
|
|
|
|
if (d > a && e > a && g > a)
|
|
return 0;
|
|
else
|
|
return -EINVAL;
|
|
}
|
|
|
|
static int test_fpu_get(void *data, u64 *val)
|
|
{
|
|
int status = -EINVAL;
|
|
|
|
kernel_fpu_begin();
|
|
status = test_fpu();
|
|
kernel_fpu_end();
|
|
|
|
*val = 1;
|
|
return status;
|
|
}
|
|
|
|
DEFINE_DEBUGFS_ATTRIBUTE(test_fpu_fops, test_fpu_get, NULL, "%lld\n");
|
|
static struct dentry *selftest_dir;
|
|
|
|
static int __init test_fpu_init(void)
|
|
{
|
|
selftest_dir = debugfs_create_dir("selftest_helpers", NULL);
|
|
if (!selftest_dir)
|
|
return -ENOMEM;
|
|
|
|
debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL,
|
|
&test_fpu_fops);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void __exit test_fpu_exit(void)
|
|
{
|
|
debugfs_remove(selftest_dir);
|
|
}
|
|
|
|
module_init(test_fpu_init);
|
|
module_exit(test_fpu_exit);
|
|
|
|
MODULE_LICENSE("GPL");
|