Xie Yongji
9632e78e82
vp_vdpa: Fix return value check for vdpa_alloc_device()
...
The vdpa_alloc_device() returns an error pointer upon
failure, not NULL. To handle the failure correctly, this
replaces NULL check with IS_ERR() check and propagate the
error upwards.
Fixes: 64b9f64f80 ("vdpa: introduce virtio pci driver")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Xie Yongji <xieyongji@bytedance.com >
Link: https://lore.kernel.org/r/20210715080026.242-2-xieyongji@bytedance.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Acked-by: Jason Wang <jasowang@redhat.com >
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com >
2021-08-11 06:44:23 -04:00
Jason Wang
1225c216d9
vp_vdpa: allow set vq state to initial state after reset
...
We used to fail the set_vq_state() since it was not supported yet by
the virtio spec. But if the bus tries to set the state which is equal
to the device initial state after reset, we can let it go.
This is a must for virtio_vdpa() to set vq state during probe which is
required for some vDPA parents.
Signed-off-by: Jason Wang <jasowang@redhat.com >
Link: https://lore.kernel.org/r/20210602021536.39525-4-jasowang@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Reviewed-by: Eli Cohen <elic@nvidia.com >
2021-07-08 07:49:02 -04:00
Jason Wang
94e48d6aaf
vp_vdpa: correct the return value when fail to map notification
...
We forget to assign a error value when we fail to map the notification
during prove. This patch fixes it.
Reported-by: kernel test robot <lkp@intel.com >
Reported-by: Dan Carpenter <dan.carpenter@oracle.com >
Fixes: 11d8ffed00 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
Signed-off-by: Jason Wang <jasowang@redhat.com >
Link: https://lore.kernel.org/r/20210624035939.26618-1-jasowang@redhat.com
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com >
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2021-07-03 04:50:52 -04:00
Stefano Garzarella
442706f9f9
vdpa: add get_config_size callback in vdpa_config_ops
...
This new callback is used to get the size of the configuration space
of vDPA devices.
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com >
Link: https://lore.kernel.org/r/20210315163450.254396-9-sgarzare@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Acked-by: Jason Wang <jasowang@redhat.com >
2021-05-03 04:55:53 -04:00
Jason Wang
526cb8580b
vp_vdpa: report doorbell address
...
This patch reports the per vq doorbell location and size to vDPA
bus. Userspace can then map the doorbell via mmap() via vhost-vDPA bus
driver.
Signed-off-by: Jason Wang <jasowang@redhat.com >
Link: https://lore.kernel.org/r/20210415073147.19331-8-jasowang@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Reviewed-by: Eli Cohen <elic@nvidia.com >
2021-05-03 04:55:52 -04:00
Jason Wang
9e311bcad7
virtio-pci library: report resource address
...
Sometimes it might be useful to report the capability physical
address. One example is to report the physical address of the doorbell
in order to be mapped by userspace.
Signed-off-by: Jason Wang <jasowang@redhat.com >
Link: https://lore.kernel.org/r/20210415073147.19331-7-jasowang@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2021-05-03 04:55:52 -04:00
Jason Wang
11d8ffed00
vp_vdpa: switch to use vp_modern_map_vq_notify()
...
This patch switches to use vp_vdpa to use vp_modern_map_notify().
Signed-off-by: Jason Wang <jasowang@redhat.com >
Link: https://lore.kernel.org/r/20210415073147.19331-4-jasowang@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Reviewed-by: Eli Cohen <elic@nvidia.com >
2021-05-03 04:55:51 -04:00
Jason Wang
64b9f64f80
vdpa: introduce virtio pci driver
...
This patch introduce a vDPA driver for virtio-pci device. It bridges
the virtio-pci control command to the vDPA bus. This will be used for
features prototyping and testing.
Note that get/restore virtqueue state is not supported which needs
extension on the virtio specification.
Signed-off-by: Jason Wang <jasowang@redhat.com >
Link: https://lore.kernel.org/r/20210223061905.422659-4-jasowang@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
2021-05-03 04:55:51 -04:00