Uwe Kleine-König
ed5c2f5fd1
i2c: Make remove callback return void
...
The value returned by an i2c driver's remove function is mostly ignored.
(Only an error message is printed if the value is non-zero that the
error is ignored.)
So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.
Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com >
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au >
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com >
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com >
Reviewed-by: Crt Mori <cmo@melexis.com >
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com >
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Acked-by: Marek Behún <kabel@kernel.org > # for leds-turris-omnia
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com >
Reviewed-by: Petr Machata <petrm@nvidia.com > # for mlxsw
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com > # for surface3_power
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com > # for bmc150-accel-i2c + kxcjk-1013
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl > # for media/* + staging/media/*
Acked-by: Miguel Ojeda <ojeda@kernel.org > # for auxdisplay/ht16k33 + auxdisplay/lcd2s
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com > # for versaclock5
Reviewed-by: Ajay Gupta <ajayg@nvidia.com > # for ucsi_ccg
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com > # for iio
Acked-by: Peter Rosin <peda@axentia.se > # for i2c-mux-*, max9860
Acked-by: Adrien Grassein <adrien.grassein@gmail.com > # for lontium-lt8912b
Reviewed-by: Jean Delvare <jdelvare@suse.de > # for hwmon, i2c-core and i2c/muxes
Acked-by: Corey Minyard <cminyard@mvista.com > # for IPMI
Reviewed-by: Vladimir Oltean <olteanv@gmail.com >
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com > # for drivers/power
Acked-by: Krzysztof Hałasa <khalasa@piap.pl >
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Signed-off-by: Wolfram Sang <wsa@kernel.org >
2022-08-16 12:46:26 +02:00
Daniel Vetter
a50f52dcc3
drm/ch7006: Stop using drm_crtc_force_disable
...
The correct way for legacy drivers to update properties that need to
do a full modeset, is to do a full modeset.
Note that we don't need to call the drm_mode_config_internal helper
because we're not changing any of the refcounted paramters.
v2: Fixup error handling (Ville). Since the old code didn't bother
I decided to just delete it instead of adding even more code for just
error handling.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com > (v1)
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20181217194303.14397-1-daniel.vetter@ffwll.ch
2019-01-11 15:56:40 +01:00
Arvind Yadav
eab18d76b6
drm: i2c: ch7006: constify i2c_device_id
...
i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: https://patchwork.freedesktop.org/patch/msgid/1503167300-17334-2-git-send-email-arvind.yadav.cs@gmail.com
2017-08-22 08:29:10 +02:00
Lukas Wunner
cfe2741550
drm/i2c/ch7006: Use helper to turn off CRTC
...
Use shiny new drm_crtc_force_disable() instead of open coding the same.
No functional change intended.
Cc: Francisco Jerez <currojerez@riseup.net >
Signed-off-by: Lukas Wunner <lukas@wunner.de >
Reviewed-by: Francisco Jerez <currojerez@riseup.net >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: http://patchwork.freedesktop.org/patch/msgid/ec7d5c06e2a21dfb8f9fc9413d3e6df86d6aa1fb.1465392124.git.lukas@wunner.de
2016-06-24 08:49:37 +02:00
Insu Yun
44084efc2f
ch7006: correctly handling failed allocation
...
Since drm_property_create_range can be failed in memory pressure,
it needs to be checked and return -ENOMEM.
Signed-off-by: Insu Yun <wuninsu@gmail.com >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
Link: http://patchwork.freedesktop.org/patch/msgid/1454025276-13465-1-git-send-email-wuninsu@gmail.com
2016-02-09 16:34:44 +01:00
Ville Syrjälä
b29483baf9
drm/i2c/ch7006: Constify function pointer structs
...
Moves a bunch of junk to .rodata from .data.
drivers/gpu/drm/i2c/ch7006.ko:
-.text 5752
+.text 5760
-.rodata 6608
+.rodata 6656
-.data 216
+.data 168
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Thierry Reding <treding@nvidia.com >
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com >
Link: http://patchwork.freedesktop.org/patch/msgid/1450178476-26284-17-git-send-email-boris.brezillon@free-electrons.com
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
2015-12-15 13:43:49 +01:00
Ville Syrjälä
b7c914b3d9
drm: Constify TV mode names
...
Make the mode names passed to drm_mode_create_tv_properties() const.
drivers/gpu/drm/i2c/ch7006.ko:
-.rodata 596
+.rodata 664
-.data 7064
+.data 6992
drivers/gpu/drm/nouveau/nouveau.ko:
-.rodata 146808
+.rodata 146904
-.data 178624
+.data 178528
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
2015-09-08 13:45:52 +02:00
Daniel Vetter
2d13b6796e
drm: encapsulate crtc->set_config calls
...
With refcounting we need to adjust framebuffer refcounts at each
callsite - much easier to do if they all call the same little helper
function.
Reviewed-by: Rob Clark <rob@ti.com >
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch >
2013-01-20 15:57:58 +01:00
Rob Clark
ec61c71d0d
drm/i2c: drm_connector_property -> drm_object_property
...
Signed-off-by: Rob Clark <rob@ti.com >
2012-11-30 10:20:12 -06:00
Mark Brown
0227a7fdc2
drm/i2c/ch7006: Convert to dev_pm_ops
...
The I2C specific suspend and resume functions have been deprecated and
printing a warning on boot for over a year, dev_pm_ops should be used
instead so convert to that.
Also remove the suspend function since all it does is log.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com >
Acked-by: Francisco Jerez <currojerez@riseup.net >
Signed-off-by: Dave Airlie <airlied@redhat.com >
2012-08-24 09:56:08 +10:00
Laurent Pinchart
e811f5ae19
drm: Make the .mode_fixup() operations mode argument a const pointer
...
The passed mode must not be modified by the operation, make it const.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Reviewed-by: Alex Deucher <alexander.deucher@amd.com >
Signed-off-by: Dave Airlie <airlied@redhat.com >
2012-07-19 21:52:38 -04:00
Sascha Hauer
d9bc3c02e3
drm: add convenience function to create an range property
...
Creating a range property is a common pattern, so create
a convenience function for this and use it where appropriate.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de >
Signed-off-by: Dave Airlie <airlied@redhat.com >
2012-02-09 10:15:25 +00:00
Paul Gortmaker
e0cd360813
gpu: add module.h to drivers/gpu files as required.
...
So that we don't get build failures once the implicit module.h
presence is removed.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com >
2011-10-31 19:32:03 -04:00
Francisco Jerez
c93ebb4021
drm/i2c/ch7006: Don't use POWER_LEVEL_FULL_POWER_OFF on early chip versions.
...
Signed-off-by: Francisco Jerez <currojerez@riseup.net >
Signed-off-by: Ben Skeggs <bskeggs@redhat.com >
2010-08-09 15:16:23 +10:00
Francisco Jerez
6d6a413aa2
drm/i2c/ch7006: Don't assume that the specified config points to static memory.
...
Signed-off-by: Francisco Jerez <currojerez@riseup.net >
Signed-off-by: Ben Skeggs <bskeggs@redhat.com >
2010-07-26 11:42:25 +10:00
Francisco Jerez
0edeb0c024
drm/i2c/ch7006: Fix up suspend/resume.
...
Signed-off-by: Francisco Jerez <currojerez@riseup.net >
Signed-off-by: Ben Skeggs <bskeggs@redhat.com >
2010-07-13 10:20:24 +10:00
Francisco Jerez
dc4a684ae8
drm/i2c/ch7006: Fix load detection false positives right after system init.
...
Signed-off-by: Francisco Jerez <currojerez@riseup.net >
Signed-off-by: Ben Skeggs <bskeggs@redhat.com >
2009-12-16 17:04:45 +10:00
Ben Skeggs
6ee738610f
drm/nouveau: Add DRM driver for NVIDIA GPUs
...
This adds a drm/kms staging non-API stable driver for GPUs from NVIDIA.
This driver is a KMS-based driver and requires a compatible nouveau
userspace libdrm and nouveau X.org driver.
This driver requires firmware files not available in this kernel tree,
interested parties can find them via the nouveau project git archive.
This driver is reverse engineered, and is in no way supported by nVidia.
Support for nearly the complete range of nvidia hw from nv04->g80 (nv50)
is available, and the kms driver should support driving nearly all
output types (displayport is under development still) along with supporting
suspend/resume.
This work is all from the upstream nouveau project found at
nouveau.freedesktop.org.
The original authors list from nouveau git tree is:
Anssi Hannula <anssi.hannula@iki.fi >
Ben Skeggs <bskeggs@redhat.com >
Francisco Jerez <currojerez@riseup.net >
Maarten Maathuis <madman2003@gmail.com >
Marcin Kościelnicki <koriakin@0x04.net >
Matthew Garrett <mjg@redhat.com >
Matt Parnell <mparnell@gmail.com >
Patrice Mandin <patmandin@gmail.com >
Pekka Paalanen <pq@iki.fi >
Xavier Chantry <shiningxc@gmail.com >
along with project founder Stephane Marchesin <marchesin@icps.u-strasbg.fr>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com >
Signed-off-by: Dave Airlie <airlied@redhat.com >
2009-12-11 21:29:34 +10:00