Uwe Kleine-König
63e34e707c
tty: vcc: Drop impossible to hit WARN_ON
...
vcc_get() returns the port that has provided port->index. As the port that
is about to be removed isn't removed yet this trivially will find this
port. So simplify the call to not assign an identical value to the port
pointer and drop the warning that is never hit.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org >
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Link: https://lore.kernel.org/r/20210114175718.137483-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-01-15 10:21:42 +01:00
Uwe Kleine-König
6da629c858
tty: vcc: Drop unnecessary if block
...
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.
So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org >
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Link: https://lore.kernel.org/r/20210114175718.137483-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-01-15 10:21:42 +01:00
Wei Yongjun
ff62255a2a
sparc64: vcc: Fix error return code in vcc_probe()
...
Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com >
Link: https://lore.kernel.org/r/20200427122415.47416-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-28 14:38:54 +02:00
Greg Kroah-Hartman
f16aa97d3f
tty: fix up a few remaining files without SPDX identifiers
...
There were a few straggling files under drivers/tty/ that did not have
any SPDX identifier either because they entered the tree recently, or
they somehow missed the mass-tagging of commit b24413180f ("License
cleanup: add SPDX GPL-2.0 license identifier to files with no license")
This commit follows the same rule as b24413180f ("License cleanup: add
SPDX GPL-2.0 license identifier to files with no license") where files
without any specified license in them fall under GPL-2.0 as the correct
license for the individual file. Add that identifier to these remaining
files so that we don't have to guess at the license of them in the
future.
Cc: Jiri Slaby <jslaby@suse.com >
Cc: "David S. Miller" <davem@davemloft.net >
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-04-04 18:48:43 +02:00
Kees Cook
4790b6dc7a
tty: vcc: Convert timers to use timer_setup()
...
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: "David S. Miller" <davem@davemloft.net >
Cc: Jiri Slaby <jslaby@suse.com >
Cc: sparclinux@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-11-04 12:01:54 +01:00
Allen Pais
a386ab2b28
drivers: tty: vcc: use setup_timer() helper.
...
Use setup_timer function instead of initializing timer with the
function and data fields.
Signed-off-by: Allen Pais <allen.lkml@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2017-10-03 20:28:36 +02:00
Bhumika Goyal
5bd0ea9107
sparc64: vcc: make ktermios const
...
Make this const as it is not modified anywhere.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-29 15:10:44 -07:00
Dan Carpenter
c6b4ee9eba
sparc64: vcc: Check for IS_ERR() instead of NULL
...
The tty_alloc_driver() function never returns NULL, it returns error
pointers on error.
Fixes: ce808b7463 ("sparc64: vcc: TTY driver initialization and cleanup")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-28 15:39:55 -07:00
Jag Raman
8f03f948ba
sparc64: vcc: Add install & cleanup TTY operations
...
Add handlers to support TTY install & cleanup operations
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:54 -07:00
Jag Raman
e942e5775c
sparc64: vcc: Add break_ctl TTY operation
...
Add handler to support TTY break_ctl operation
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:54 -07:00
Jag Raman
aeee7debf3
sparc64: vcc: Add chars_in_buffer TTY operation
...
Add handler to support TTY chars_in_buffer operation
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:54 -07:00
Jag Raman
cf0452600b
sparc64: vcc: Add write & write_room TTY operations
...
Add handlers to support TTY write & write_room operations
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:53 -07:00
Jag Raman
6a3ff25bc6
sparc64: vcc: Add hangup TTY operation
...
Add handler to support TTY hangup operation
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:53 -07:00
Jag Raman
63a7174484
sparc64: vcc: Add open & close TTY operations
...
Add handlers to support TTY open & close operations
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:53 -07:00
Jag Raman
103b9b0bc9
sparc64: vcc: Enable LDC event processing engine
...
Enable event processing engine to handle LDC events
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:52 -07:00
Jag Raman
f8c553354e
sparc64: vcc: Add RX & TX timer for delayed LDC operation
...
Add RX & TX timers to perform delayed/asynchronous LDC
read and write operations.
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:52 -07:00
Jag Raman
8868e44a56
sparc64: vcc: Create sysfs attribute group
...
Create sysfs attribute group to show the domain name and
send break command.
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:52 -07:00
Jag Raman
5d171050e2
sparc64: vcc: Enable VCC port probe and removal
...
Enables VCC port probe and removal to initialize and terminate
VCC ports respectively. When a device/port matching the VCC driver
is added, the probe function is invoked along with a reference
to the device. remove function is called when the device is
removed.
Also add APIs to cache and retrieve VCC ports from a VCC table
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:51 -07:00
Jag Raman
ce808b7463
sparc64: vcc: TTY driver initialization and cleanup
...
Allocate and register TTY driver during module init. Cleanup
TTY driver during module exit.
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:51 -07:00
Jag Raman
f283ebd564
sparc64: vcc: Add VCC debug message macros
...
Add C macros to print debug messages from VCC module
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:51 -07:00
Jag Raman
55bd2133fc
sparc64: vcc: Enable VCC module in linux
...
Enables the Virtual Console Concentrator (VCC) module
in linux kernel
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com >
Reviewed-by: Liam Merwick <liam.merwick@oracle.com >
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-08-15 21:33:50 -07:00