Aaro Koskinen
5669601d92
staging: octeon-usb: use list.h for transactions
...
Use list.h helpers for transactions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:46:00 -07:00
Aaro Koskinen
4a23ee1bd7
staging: octeon-usb: use list.h for pipes
...
Use list.h helpers for pipes.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:46:00 -07:00
Aaro Koskinen
f011fefa8a
staging: octeon-usb: use list_for_each_entry_safe()
...
Use list_for_each_entry_safe() when deleting all list items.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:46:00 -07:00
Aaro Koskinen
244544a185
staging: octeon-usb: use list_del_init()
...
Replace list_del() + INIT_LIST_HEAD() with list_del_init().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:45:59 -07:00
Aaro Koskinen
d2695a8a3d
staging: octeon-usb: use dynamic allocation for pipes
...
Use dynamic memory allocation for pipes.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:45:59 -07:00
Aaro Koskinen
a2dfef06e6
staging: octeon-usb: use dynamic allocation for transactions
...
Use dynamic memory allocation for transactions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:45:59 -07:00
Aaro Koskinen
f121910396
staging: octeon-usb: use a single .h file
...
Merge USBC and USBN register definitions into a single header
file. Although all HW definitions are purely internal to the driver,
it's better to keep them separate due to the large size of the file.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:45:59 -07:00
Aaro Koskinen
7d7bc26b1d
staging: octeon-usb: CN3xxx: program p_xenbn and p_rclk through p_rtype
...
Do the clock setup through p_rtype on all OCTEONs. This enables to get
rid of duplicated register definitions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:45:59 -07:00
Aaro Koskinen
34b70b9e05
staging: octeon-usb: delete cvmx_usbnx_clk_ctl_cn50xx
...
Add the missing bits to common clk ctl definition, and we can delete
duplicated definitions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:45:59 -07:00
Aaro Koskinen
d8d8e148fd
staging: octeon-usb: delete unused cvmx_usbnx_usbp_ctl_status definitions
...
cvmx_usbnx_usbp_ctl_status was multiplied for different OCTEONS and all
those definitions are unused. Delete them.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-11 15:45:58 -07:00
Aaro Koskinen
aa87afe207
staging: octeon-usb: refactor __cvmx_usb_pipe_needs_split
...
Split a long line and remove redundant parenthesis.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:22 -07:00
Aaro Koskinen
3e1674c093
staging: octeon-usb: eliminate submit_handle
...
Eliminate submit_handle, use a direct reference instead.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
60f815078f
staging: octeon-usb: eliminate pipe_handle
...
Eliminate pipe_handle, use a direct reference instead.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
be44063df5
staging: octeon-usb: clean up hcpriv usage
...
Use ep->hcpriv for pipe handle and urb->hcpriv for submit handle,
instead of packing both into the same field.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
e16b5e3f14
staging: octeon-usb: cvmx_usb_submit_control: get params from urb
...
Get the transfer parameters from urb.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
9fdbb6964b
staging: octeon-usb: cvmx_usb_submit_interrupt: get params from urb
...
Get the transfer parameters from urb.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
2ae09e8721
staging: octeon-usb: cvmx_usb_submit_control: get params from urb
...
Get the transfer parameters from urb.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
9ccca70718
staging: octeon-usb: cvmx_usb_submit_bulk: get params from urb
...
Get the transfer parameters from urb.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
0cce1004c1
staging: octeon-usb: replace generic transfer callback data with urb
...
URB is always passed, so we can use strong typing here.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
75ee512487
staging: octeon-usb: call transfer completion callback directly
...
The callback is always the same, we can just call it directly.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
393e214686
staging: octeon-usb: call port change callback directly
...
Call port change callback directly.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
29a202fa76
staging: octeon-usb: inline cvmx_usb_set_status
...
Inline a trivial function.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
cb61c60098
staging: octeon-usb: eliminate cvmx_usb_internal_state
...
Eliminate cvmx_usb_internal_state, just use cvmx_usb_state everywhere.
This also enables to allocate only the needed amount of data for the
USB internal state, instead of always allocating 64 KB.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
6570b4a991
staging: octeon-usb: merge cvmx-usb into octeon-hcd
...
cvmx-usb module provided Cavium "OS abstraction layer" for USB
functionality. To make this driver a proper Linux driver, we need to
refactor this layer out. By making all the code internal to the HCD
driver makes this task easier.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-06 22:02:21 -07:00
Aaro Koskinen
72b80113a6
staging: octeon-usb: cvmx-usb.h: make comments to fit into 80 columns
...
Make comments to fit into 80 columns.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:12 -07:00
Aaro Koskinen
ab09e5c148
staging: octeon-usb: cvmx-usb.c: make comments to fit into 80 columns
...
Make comments to fit into 80 columns.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:06 -07:00
Aaro Koskinen
d0adff6acd
staging: octeon-usb: cvmx-usb: delete unused macros
...
Delete unused cvmx_read_csr / cvmx_write_csr macros.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:06 -07:00
Aaro Koskinen
5bffcff517
staging: octeon-usb: eliminate CVMX_PREFETCH_PREFX
...
Eliminate CVMX_PREFETCH_PREFX.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:06 -07:00
Aaro Koskinen
1e50e9ac31
staging: octeon-usb: eliminate CVMX_PREFETCH_PREF0
...
Eliminate CVMX_PREFETCH_PREF0.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:06 -07:00
Aaro Koskinen
10828735df
staging: octeon-usb: delete CVMX_PREFETCH128
...
Delete unused macro.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:06 -07:00
Aaro Koskinen
5e77a281eb
staging: octeon-usb: inline CVMX_PREFETCH0
...
Inline CVMX_PREFETCH0 macro.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:05 -07:00
Aaro Koskinen
e50aa24e79
staging: octeon-usb: replace CVMX_CLZ with __fls()
...
Replace CVMX_CLZ macro with __fls().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:05 -07:00
Aaro Koskinen
e43de55ce2
staging: octeon-usb: delete redundant flags from cvmx_usb_open_pipe()
...
Delete redudant flags parameter.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:05 -07:00
Aaro Koskinen
951a444c61
staging: octeon-usb: delete redundant flags from __cvmx_usb_submit_transaction()
...
Delete redundant flags parameter.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:05 -07:00
Aaro Koskinen
5dc0316c1b
staging: octeon-usb: delete cvmx_usb_isochronous_flags
...
Delete unused flags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:05 -07:00
Aaro Koskinen
9be317e69e
staging: octeon-usb: delete redundant flags from cvmx_usb_initialize()
...
The function will always figure out the used clock internally, so delete
a redudant parameter and the flag.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-10-03 13:38:05 -07:00
Thomas Meyer
0a69bb4691
staging: octeon-usb: Cocci spatch "noderef"
...
sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"
Signed-off-by: Thomas Meyer <thomas@m3y3r.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-09-25 16:53:39 -07:00
Aaro Koskinen
b9cc16c03d
staging: octeon-usb: eliminate remaining typedef unions
...
Remaining typedef unions can be trivially eliminated with the pattern:
foo_t -> union foo
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:50 -07:00
Aaro Koskinen
47509e4a9c
staging: octeon-usb: cvmx_usb_control_header_t -> union cvmx_usb_control_header
...
Replace cvmx_usb_control_header_t with union cvmx_usb_control_header.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:49 -07:00
Aaro Koskinen
2bf249e482
staging: octeon-usb: cvmx_usb_internal_state_t -> struct cvmx_usb_internal_state
...
Replace cvmx_usb_internal_state_t with struct cvmx_usb_internal_state.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:48 -07:00
Aaro Koskinen
0ff6ac84f9
staging: octeon-usb: cvmx_usb_tx_fifo_t -> struct cvmx_usb_tx_fifo
...
Replace cvmx_usb_tx_fifo_t with struct cvmx_usb_tx_fifo_t.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:47 -07:00
Aaro Koskinen
bb06528d6e
staging: octeon-usb: cvmx_usb_pipe_list_t -> struct cvmx_usb_pipe_list
...
Replace cvmx_usb_pipe_list_t with struct cvmx_usb_pipe_list.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:46 -07:00
Aaro Koskinen
4ec3ae8412
staging: octeon-usb: cvmx_usb_pipe_t -> struct cvmx_usb_pipe
...
Replace cvmx_usb_pipe_t with struct cvmx_usb_pipe.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:46 -07:00
Aaro Koskinen
48f61f832d
staging: octeon-usb: cvmx_usb_transaction_t -> struct cvmx_usb_transaction
...
Replace cvmx_usb_transaction_t with struct cvmx_usb_transaction.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:45 -07:00
Aaro Koskinen
a24ed35a19
staging: octeon-usb: cvmx_usb_state_t -> struct cvmx_usb_state
...
Replace cvmx_usb_state_t with struct cvmx_usb_state.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:44 -07:00
Aaro Koskinen
6e0e1b0069
staging: octeon-usb: cvmx_usb_iso_packet_t -> struct cvmx_usb_iso_packet
...
Replace cvmx_usb_iso_packet_t with struct cvmx_usb_iso_packet.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:43 -07:00
Aaro Koskinen
51a19621cc
staging: octeon-usb: cvmx_usb_port_status_t -> struct cvmx_usb_port_status
...
Replace cvmx_usb_port_status_t with struct cvmx_usb_port_status.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:51:43 -07:00
Aaro Koskinen
03f9adf44c
staging: octeon-usb: cvmx_usb_stage_t -> enum cvmx_usb_stage
...
Replace cvmx_usb_stage_t with enum cvmx_usb_stage.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:50:10 -07:00
Aaro Koskinen
4f1d6ba901
staging: octeon-usb: cvmx_usb_transaction_flags_t -> enum cvmx_usb_transaction_flags
...
Replace cvmx_usb_transaction_flags_t with enum cvmx_usb_transaction_flags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:50:09 -07:00
Aaro Koskinen
ff9a3e3982
staging: octeon-usb: cvmx_usb_isochronous_flags_t -> enum cvmx_usb_isochronous_flags
...
Replace cvmx_usb_isochronous_flags_t with enum cvmx_usb_isochronous_flags.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2013-07-31 17:50:08 -07:00