Commit Graph

1099 Commits

Author SHA1 Message Date
Florian Schmaus
70fe742c94 staging: comedi_fops.c whitespace fixes
Changed whitespaces in comedi/*.c to tabs where necessary. All .c
files within comedi now have no obvious style problems as reported by
checkpatch.pl

Signed-off-by: Florian Schmaus <fschmaus@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-16 10:54:15 -08:00
Ravishankar karkala Mallikarjunayya
89c5db0962 Staging: comedi: fix printk issue in contec_pci_dio.c
This is a patch to the contec_pci_dio.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_dbg().

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:41:14 -08:00
Ravishankar karkala Mallikarjunayya
cecdee8551 Staging: comedi: fix printk issue in das1800.c
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printk to dev_<levels>.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:39:46 -08:00
Ravishankar karkala Mallikarjunayya
7cf372b1c4 Staging: comedi: fix printk issue in das1800.c
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Included KERN_facility levels for printk.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:39:43 -08:00
Ravishankar karkala Mallikarjunayya
6c6c227d2a Staging: comedi: fix printk issue in cb_pcidas64.c
This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels> and Removed unnecessary
printk statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:37:35 -08:00
Ravishankar karkala Mallikarjunayya
d78678dad3 Staging: comedi: fix printk issue in cb_pcidas64.c
This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels> and Removed unnecessary
printk statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:37:11 -08:00
Ravishankar karkala Mallikarjunayya
94cc0b4a6e Staging: comedi: fix printk issue in cb_pcidas.c
This is a patch to the cb_pcidas.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels>..

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:33:40 -08:00
Ravishankar karkala Mallikarjunayya
aa4b8c7258 Staging: comedi: fix printk issue in cb_pcidas.c
This is a patch to the cb_pcidas.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_dbg()..

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:33:39 -08:00
Ravishankar karkala Mallikarjunayya
7a647b9e4a Staging: comedi: fix printk issue in das1800.c
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_dbg().

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:33:38 -08:00
Ravishankar karkala Mallikarjunayya
1e3a287568 Staging: comedi: fix printk issue in das1800.c
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Coverted printks to dev_<levels>.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:33:38 -08:00
Ravishankar karkala Mallikarjunayya
e2499d5c0d Staging: comedi: fix printk issue in daqboard2000.c
This is a patch to the daqboard2000.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_dbg().

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:33:37 -08:00
Ravishankar karkala Mallikarjunayya
904c02968b Staging: comedi: fix printk issue in das1800.c
This is a patch to the das1800.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels>.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:33:36 -08:00
Ravishankar karkala Mallikarjunayya
a96b98f218 Staging: comedi: fix brace coding style issue in ni_at_a2150.c
This is a patch to the ni_at_a2150.c file that fixes up a brace
warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:31:10 -08:00
Ravishankar karkala Mallikarjunayya
351a1d35d6 Staging: comedi: fix printk issue in jr3_pci.c
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels> and Removed unnecessary
printk statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:31:09 -08:00
Ravishankar karkala Mallikarjunayya
2c2fedf2c4 Staging: comedi: fix printk issue in jr3_pci.c
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_dbg().

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:31:08 -08:00
Ravishankar karkala Mallikarjunayya
5ec8df5e46 Staging: comedi: fix printk issue in daqboard2000.c
This is a patch to the daqboard2000.c file that fixes up a printk
warning found by the checkpatch.pl tool.

converted printks to dev_printk and Removed unnecessary
printk statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:25:09 -08:00
Ravishankar karkala Mallikarjunayya
aaed839599 Staging: comedi: fix printk issue in daqboard2000.c
This is a patch to the daqboard2000.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Converted printks to dev_dbg().

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:25:02 -08:00
Ravishankar karkala Mallikarjunayya
976fe5ab27 Staging: comedi: fix printk issue in pcmuio.c
This is a patch to the pcmuio.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Converted printks to dev_dbg().

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:25:01 -08:00
Ravishankar karkala Mallikarjunayya
deb04291a1 Staging: comedi: fix printk issue in pcmuio.c
This is a patch to the pcmuio.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Converted printks to dev_functions.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:25:00 -08:00
Ravishankar karkala Mallikarjunayya
de1201ea91 Staging: comedi: fix printk issue in pcmuio.c
This is a patch to the pcmuio.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Converted printks to dev_functions.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:25:00 -08:00
Ravishankar karkala Mallikarjunayya
750d80bdac Staging: comedi: fix printk issue in dt3000.c
This is a patch to the dt3000.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Converted printks to dev_<levels>.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:24:59 -08:00
Ravishankar karkala Mallikarjunayya
5cf76a8bf8 Staging: comedi: fix printk issue in dt3000.c
This is a patch to the dt3000.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Converted printks to dev_functions.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:24:58 -08:00
Ravishankar karkala Mallikarjunayya
23aff74c1a Staging: comedi: fix printk issue in dt3000.c
This is a patch to the dt3000.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels>.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:24:58 -08:00
Ravishankar karkala Mallikarjunayya
a65df79746 Staging: comedi: fix printk issue in dt3000.c
This is a patch to the dt3000.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Added KERN_facility levels.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:24:57 -08:00
Ravishankar karkala Mallikarjunayya
b6b31e972d Staging: comedi: fix printk issue in dt3000.c
This is a patch to the dt3000.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels>.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:24:56 -08:00
Ravishankar karkala Mallikarjunayya
c1f7d31144 Staging: comedi: fix printk issue in jr3_pci.c
This is a patch to the jr3_pci.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Added KERN_facility levels for printks.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-13 16:22:17 -08:00
Greg Kroah-Hartman
407f3fd8fa Merge 3.2-rc5 into staging-next
This resolves the conflict in the
drivers/staging/iio/industrialio-core.c file due to two different
changes made to resolve the same problem.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-09 19:01:27 -08:00
Ravishankar karkala Mallikarjunayya
036f419529 Staging: comedi: fix initialise statics to 0 or NULL issue in cb_das16_cs.c
This is a patch to the cb_das16_cs.c file that fixes up a initialise
statics to 0 or NULL warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 16:05:21 -08:00
Ravishankar karkala Mallikarjunayya
6f2c5f3852 Staging: comedi: fix initialise statics to 0 or NULL issue in dt3000.c
This is a patch to the dt3000.c file that fixes up a initialise
statics to 0 or NULL warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 16:04:26 -08:00
Ravishankar karkala Mallikarjunayya
41912a3f23 Staging: comedi: fix line over 80 character issue in cb_pcimdda.c
This is a patch to the cb_pcimdda.c file that fixes up a
line over 80 character warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 16:04:26 -08:00
Ravishankar karkala Mallikarjunayya
5f1d0f3f3f Staging: comedi: fix brace coding style issue in daqboard2000.c
This is a patch to the daqboard2000.c file that fixes up a brace
warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 16:04:25 -08:00
Florian Schmaus
c5018168a5 staging: comedi: comedi_fops: Removed int overflow check
This became unnecessary with the previous commit.
Improved the readability of the remaining check, by using UINT_MAX.

Signed-off-by: Florian Schmaus <fschmaus@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 15:59:09 -08:00
Florian Schmaus
2e1c394fc3 staging: comedi: comedi_fops: Replace deprecated strict_strtoul with kstrtouint
As reported by checkpatch.pl strict_strtoul should be replaced. It was
replaced with kstrtouint since async->max_bufsize is an unsigned int
anyway.

Signed-off-by: Florian Schmaus <fschmaus@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 15:59:08 -08:00
Dan Carpenter
2f30866fbf Staging: comedi: unlock on error in usbduxsigma_attach()
We should release the udev->sem lock before returning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 12:29:40 -08:00
Dan Carpenter
d6610a5027 Staging: comedi: unlock on error in usbdux_ao_inttrig()
If we had an invalid trignum (anything other than zero is invalid) then
we returned without unlocking.  I've modified this function to just have
one return point.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-12-08 12:29:39 -08:00
Xi Wang
dfd8ee92a9 Staging: comedi: fix integer overflow in do_insnlist_ioctl()
There is a potential integer overflow in do_insnlist_ioctl() if
userspace passes in a large insnlist.n_insns.  The call to kmalloc()
would allocate a small buffer, leading to a memory corruption.

The bug was reported by Dan Carpenter <dan.carpenter@oracle.com>
and Haogang Chen <haogangchen@gmail.com>.  The patch was suggested by
Ian Abbott <abbotti@mev.co.uk> and Lars-Peter Clausen <lars@metafoo.de>.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Haogang Chen <haogangchen@gmail.com>.
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-28 04:38:45 +09:00
Greg Kroah-Hartman
06b446c8af Revert "Staging: comedi: integer overflow in do_insnlist_ioctl()"
This reverts commit e384a41141.
It's not the correct way to solve this issue.

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-28 04:36:10 +09:00
Ravishankar karkala Mallikarjunayya
0389245f0c Staging: comedi: fix brace coding style issue in pcmuio.c
This is a patch to the pcmuio.c file that fixes up a brace
warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:41 -08:00
Ravishankar karkala Mallikarjunayya
34dac67d6c Staging: comedi: fix printk issue in ni_pcimio.c
This is a patch to the ni_pcimio.c file that fixes up a printk
warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:40 -08:00
Ravishankar karkala Mallikarjunayya
e8f31fd312 Staging: comedi: fix printk issue in ni_pcimio.c
This is a patch to the ni_pcimio.c file that fixes up a printk
warning found by the checkpatch.pl tool.
Converted printks to dev_<level> and pr_<level>.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:40 -08:00
Ravishankar karkala Mallikarjunayya
25c0ca8406 Staging: comedi: fix brace coding style issue in ni_pcimio.c
This is a patch to the ni_pcimio.c file that fixes up a brace
warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:40 -08:00
Ravishankar karkala Mallikarjunayya
327ffc0ce7 Staging: comedi: fix printk issue in ni_labpc_cs.c
This is a patch to the ni_labpc_cs.c file that fixes up a printk
warning found by the checkpatch.pl tool

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:40 -08:00
Ravishankar karkala Mallikarjunayya
1aa301e83b Staging: comedi: fix printk issue in ni_daq_dio24.c
This is a patch to the ni_daq_dio24.c file that fixes up a printk
warning found by the checkpatch.pl tool.
Converted printks to pr_<levels> and dev_version.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:40 -08:00
Ravishankar karkala Mallikarjunayya
ef7908ebc3 Staging: comedi: fix brace coding style issue in ni_daq_dio24.c
This is a patch to the ni_daq_dio24.c file that fixes up a
brace warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:40 -08:00
Ravishankar karkala Mallikarjunayya
73b12a5bc0 Staging: comedi: fix initialise statics to 0 or NULL issue in ni_daq_dio24.c
This is a patch to the ni_daq_dio24.c file that fixes up a initialise
statics to 0 or NULL warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:51:40 -08:00
Ravishankar karkala Mallikarjunayya
408f6bcd2a Staging: comedi: fix printk issue in pcl818.c
This is a patch to the pcl818.c file that fixes up a printk
warning found by the checkpatch.pl tool.
Removed an unnecessary printks.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:50:46 -08:00
Ravishankar karkala Mallikarjunayya
c62a0ef42c Staging: comedi: fix printk issue in pcl818.c
This is a patch to the pcl818.c file that fixes up a printk
warning found by the checkpatch.pl tool.
Converted printks to dev_version.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:50:46 -08:00
Ravishankar karkala Mallikarjunayya
26ba666c50 Staging: comedi: fix printk issue in pcl818.c
This is a patch to the pcl818.c file that fixes up a printk
warning found by the checkpatch.pl tool

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:50:46 -08:00
Ravishankar karkala Mallikarjunayya
3478f74231 Staging: comedi: fix printk issue in das16m1.c
This is a patch to the das16m1.c file that fixes up a printk
warning found by the checkpatch.pl tool.

converted printks to comedi_<level.
Removed an unnecessary printk statment.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:50:46 -08:00
Ravishankar karkala Mallikarjunayya
b147ed6077 Staging: comedi: fix initialise statics to 0 or NULL issue in pcl816.c
This is a patch to the pcl816.c file that fixes up a initialise statics to 0 or NULL
warning found by the checkpatch.pl tool.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-11-26 18:50:45 -08:00