Gustavo A. R. Silva
6a8ce97113
staging: vt6655: Fix fall-through warnings for Clang
...
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
Link: https://lore.kernel.org/r/863fda60074850bc976974af48fa769c64725e64.1605896059.git.gustavoars@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-23 17:55:23 +01:00
Marcos Antonio de Jesus Filho
0d79a48440
staging: vt6655: Remove useless else
...
The else statements are not useful due to the presence of a return
statement on the if block. Remove the else statements, adjust the
indentation of the code, move variable declarations to the beginning of
their scope and remove useless return statement. Reported by checkpatch.
Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com >
Link: https://lore.kernel.org/r/20201109025641.GA69196@Zangetsu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:35:21 +01:00
Marcos Antonio de Jesus Filho
36f18e741a
staging: vt6655: Fix typo
...
Fix typo reported by checkpatch.
Signed-off-by: Marcos Antonio de Jesus Filho <mdejesusfilho@gmail.com >
Link: https://lore.kernel.org/r/20201026201714.GA24239@Zangetsu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-10-27 12:23:44 +01:00
Deepak R Varma
2ed1fa08e6
staging: vt6655: rearrange lines exceeding 100 columns
...
Rearrange lines that are longer than 100 columns in width. Issue reported
by chckpatch script. Also remove unnecessary pair of braces for single
line instruction post if condition.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com >
Link: https://lore.kernel.org/r/20201016154423.GA17210@ubuntu204
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-10-26 06:53:10 +01:00
Sebastian Fuentes
9a9c1827e7
staging: vt6655: Add spaces around arithmetic operators
...
This addresses the checkpatch.pl warning "spaces preferred around that
'+/-/*'"
Signed-off-by: Sebastian Fuentes <sefu1789@gmail.com >
Link: https://lore.kernel.org/r/20200912052357.GA4707@ubuntu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-09-13 09:20:38 +02:00
Gustavo A. R. Silva
deb34767b2
staging: vt6655: Use fallthrough pseudo-keyword
...
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
Link: https://lore.kernel.org/r/20200707194350.GA3255@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-07-10 13:52:46 +02:00
Vaibhav Gupta
7a46931ba9
staging: vt6655/device_main.c: use generic power management
...
Drivers should not use legacy power management as they have to manage power
states and related operations, for the device, themselves. This driver was
handling them with the help of PCI helper functions like
pci_save/restore_state(), pci_enable/disable_device(), etc.
With generic PM, all essentials will be handled by the PCI core. Driver
needs to do only device-specific operations.
The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use
device_wakeup_disable() instead.
Compile-tested only.
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com >
Link: https://lore.kernel.org/r/20200629082819.216405-5-vaibhavgupta40@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-07-01 15:39:21 +02:00
Rodolfo C. Villordo
79e88fd45b
drivers: staging: vt6655: replace CamelCase names on function s_uGetRTSCTSRsvTime
...
Replace function and variables name from CamelCase style to snake_case style.
Remove Hungarian notation.
Signed-off-by: Rodolfo C. Villordo <rodolfovillordo@gmail.com >
Link: https://lore.kernel.org/r/20200624100256.GA17118@ip-172-31-24-31.ec2.internal
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-06-25 15:40:27 +02:00
Matej Dujava
3abbab5132
staging: vt6656: vt6655: removing unused macros definition Makefiles
...
This patch is removing definition of CFLAGS in Makefile of vt6656 and
vt6655, as those are defining macros that are not used. This will remove
undef of one macro from vt6655/device_main.c, as it is only undef and it is
not used anywhere else, so it is safe to remove it.
Macros are removed from vt665x/Makefile and vt6655/device_main.c.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1589397351-24655-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-15 15:49:13 +02:00
Matej Dujava
0729bb9b2a
staging: vt6655: fix LONG_LINE warning
...
This patch will fix LONG_LINE error from checkpatch, by using ternary
operator.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1588520570-14388-3-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-05 12:33:00 +02:00
Matej Dujava
3fc29573cf
staging: vt6655: return early if not bNeedAck
...
This patch will check for bNeedAck before making bb_get_frame_time call, so
in case we dont need uAckTime, we can return early.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1588520570-14388-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-05 12:32:59 +02:00
Matej Dujava
e3b8577aa1
staging: vt6655: extract index manupulation out of function call
...
This patch will remove if/else by selecting proper argument before
function call, also index is updated before function call.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1588512552-12297-6-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-05 12:31:19 +02:00
Matej Dujava
ae25983134
staging: vt6655: return at the ond of case body
...
This patch will unify exit point for s_uGetDataDuration function.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1588512552-12297-5-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-05 12:31:19 +02:00
Matej Dujava
3be1acffe6
staging: vt6655: remove else after return and invert condition
...
This patch will prepare us to make return at the end of case body
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1588512552-12297-4-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-05 12:31:19 +02:00
Matej Dujava
0ae73acc44
staging: vt6655: do calculation of uAckTime first
...
This patch is extracting calculation of uAckTime in one place, at the
start of case body.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1588512552-12297-3-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-05 12:31:18 +02:00
Matej Dujava
e4a34ef772
staging: vt6655: merge two switch cases in s_uGetDataDuration
...
This patch will reuse code for two cases.
Signed-off-by: Matej Dujava <mdujava@kocurkovo.cz >
Link: https://lore.kernel.org/r/1588512552-12297-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-05-05 12:31:18 +02:00
Briana Oursler
af93096eef
Staging: vt6655: Replace camel case variable names.
...
Replace camel case variable names with snake case in baseband.h and its
dependencies.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200403171805.466600-1-briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:31 +02:00
Briana Oursler
3d7b79f2ee
Staging: vt6655: Remove BBvExitDeepSleep definition.
...
Remove function BBvExitDeepSleep that is never called.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/027b00a27e2bef13c1daab3514dc7dc19fa1aa00.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:27 +02:00
Briana Oursler
3d1f39e962
Staging: vt6655: Remove CARDbRadioPowerOn definition.
...
Remove function CARDbRadioPowerOn that is never called, along with
comments related to it.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/e64c02aadd0b846604c755989b39f374161a87e0.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:27 +02:00
Briana Oursler
5ec64e91d3
Staging: vt6655: Remove CARDvSetLoopbackMode definition.
...
Remove function CARDvSetLoopbackMode that is never called, along with
comments related to it.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/b81f06ebc0179fbceb43c085411b372ff909b134.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:27 +02:00
Briana Oursler
1ad93e3166
Staging: vt6655: Remove CARDbSoftwareReset definition.
...
Remove function CARDbSoftwareReset that is never called, along with
comments related to it.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/8ec491439b947c959fab52e006d9ca26ec3657ab.1585802818.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:27 +02:00
Briana Oursler
2f7ccc387c
Staging: vt6655: Format long lines.
...
Add whitespace around '-' operator and wrap long lines. Issue found by
checkpatch.pl.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/e1c9fc822f1576f9896799fea6c467457cf0f6da.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:27 +02:00
Briana Oursler
b03ee7b2b8
Staging: vt6655: Eliminate nested if else
...
Eliminate nested if else statement, reduce code duplication, and
shorten long lines by creating a new variable, len, to determine
function input needed for s_uGetTxRsvTime.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/301ff66e13e76be6416b5c0f8359249fa25f08e3.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:26 +02:00
Briana Oursler
e781fd1b33
Staging: vt6655: Move rate determination logic.
...
Factor rate setting logic out of nested if-else statement to prevent
code duplication.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/ba87af8a2d28d5737c6d8888bbda143aad723d2c.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:26 +02:00
Briana Oursler
5b0578364f
Staging: vt6655: Limit return statements.
...
Limit return statements within context of switch case to improve
readability.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/fe417533b66d29ef6ea19128b38b8c8de7757ae2.1585763457.git.briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:26 +02:00
Briana Oursler
6f5ec72252
Staging: vt6655: Remove BBvCalculateParameter comment.
...
Remove comment that refers to function that no longer exists.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200328200331.136265-1-briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:26 +02:00
Briana Oursler
81a13643f8
staging: vt6655: Remove multiple assignments.
...
Remove multiple assignments at initialization and in computations to
better match Linux style. Issue found by checkpatch.pl.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/20200327192700.12289-1-briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-04-13 08:55:26 +02:00
Briana Oursler
73d854226a
staging: vt6655: Break up function call with long line.
...
Update matches style found elsewhere in file.
Issue found by checkpatch: line over 80 characters.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Link: https://lore.kernel.org/r/20200324183812.79411-1-briana.oursler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-25 13:40:14 +01:00
Lourdes Pedrajas
d154c0a968
staging: vt6655: power.c: code reformatting for improved readability
...
Improve line grouping for better understanding the course of action and where
every comment belongs to.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/3fada7fe76047ecf06d0345c0ab9216424a126f2.1583848946.git.lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Lourdes Pedrajas
3cd8958935
staging: vt6655: power.c: Remove setting ATIM Window in PSvEnablePowerSaving()
...
Every time priv->op_mode is not NL80211_IFTYPE_ADHOC it sets ATIM Window, but
this feature it is marked TODO in 2014 and did go untouched since 2015.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net >
Reviewed-by: Stefano Brivio <sbrivio@redhat.com >
Link: https://lore.kernel.org/r/d9b8e434e09cb8885026a71441bf3a6919dba3da.1583848946.git.lu@pplo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-11 08:08:49 +01:00
Payal Kshirsagar
a632b9faec
staging: vt6655: alignment should match open parenthesis
...
Align code to the open parenthesis to fix the alignment issue.
Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com >
Link: https://lore.kernel.org/r/20200309170927.6171-1-payalskshirsagar1234@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-03-10 10:15:21 +01:00
Simon Fong
a1182cda0c
Staging: vt6655: device_main: cleanup long line
...
cleanup a long line coding style warning.
Signed-off-by: Simon Fong <simon.fongnt@yahoo.com >
Link: https://lore.kernel.org/r/20200128141426.12230-1-simon.fongnt@yahoo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-02-09 16:22:56 -08:00
Colin Ian King
32f78c901d
staging: vt6655: remove redundant assignment to variable ret
...
The variable ret is being initialized with a value that
is never read and is being re-assigned later on. The
assignment is redundant and hence can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Link: https://lore.kernel.org/r/20200114171145.375356-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-01-15 13:11:41 +01:00
Frank A. Cancio Bello
3bce4750c9
staging: vt6655: Fix long lines
...
Lines longer than 80 characters should be avoided because they are ugly
and harder to read. Fix a few of long lines to comply with the preferred
coding style for the linux kernel. Issues found by checkpatch.
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr >
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com >
Link: https://lore.kernel.org/r/588c73f275b22f55323797706e5ceae44d7aa160.1572649242.git.frank@generalsoftwareinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-11-03 13:09:00 +01:00
Frank A. Cancio Bello
31d0c9d9b7
staging: vt6655: Fix open ended lines
...
This commit arrange function declaration in one line to avoid lines
ending with '(' and comply in that way with the preferred coding
style for the linux kernel.
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr >
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com >
Link: https://lore.kernel.org/r/bdbc1d472a8d90487d691e82ab8154a5733e6a0f.1572649242.git.frank@generalsoftwareinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-11-03 13:09:00 +01:00
Frank A. Cancio Bello
ebacc1a765
staging: vt6655: Fix the spacing around operators
...
Add space around operators to comply in that way with the preferred
coding style for the linux kernel. Issue found by checkpatch.
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr >
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com >
Link: https://lore.kernel.org/r/0f77b97e88c28c503caf25fafb84729509969ec3.1572649242.git.frank@generalsoftwareinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-11-03 13:09:00 +01:00
Frank A. Cancio Bello
8b3f9afcca
staging: vt6655: Fix parameter alignment issues
...
Fix alignment to match open parenthesis and comply in that way with the
preferred coding style for the linux kernel. Issue found by checkpatch.
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr >
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com >
Link: https://lore.kernel.org/r/df2a5f511870bd96abb9b111de83f3a1f1d82d70.1572649242.git.frank@generalsoftwareinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-11-03 13:09:00 +01:00
Cristiane Naves
6e0afa355a
staging: vt6655: Fix lines ending with parentheses
...
Fix lines ending with parentheses. Issue found by checkpatch.
Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com >
Link: https://lore.kernel.org/r/20191029210917.GA14956@cristiane-Inspiron-5420
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-10-30 10:38:48 +01:00
Navid Emamdoost
80b15db5e1
staging: vt6655: Fix memory leak in vt6655_probe
...
In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
like other error handling cases. The call to device_free_info() is
added.
Fixes: 67013f2c0e ("staging: vt6655: mac80211 conversion add main mac80211 functions")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com >
Cc: stable <stable@vger.kernel.org >
Link: https://lore.kernel.org/r/20191004200319.22394-1-navid.emamdoost@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-10-07 12:34:55 +02:00
Geert Uytterhoeven
0c20037c67
staging: Add missing newline at end of file
...
"git diff" says:
\ No newline at end of file
after modifying the files.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-06-18 08:59:40 +02:00
Nishka Dasgupta
d7255ba4d6
staging: vt6655: Change return type of function and remove variable
...
Remove return variable bResult from function CARDbRadioPowerOff and
change the return type of the function to void as it always returns true
and the return value is never stored nor checked when called.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-06-03 14:19:33 +02:00
Moses Christopher
cc9daca6e0
staging: vt665*: use help instead of ---help--- in Kconfig
...
- Resolve the following warning from the Kconfig,
"WARNING: prefer 'help' over '---help---' for new help texts"
Signed-off-by: Moses Christopher <moseschristopherb@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-05-20 10:49:08 +02:00
Cesar Santos
9fdb04e9cc
staging: vt6655: upc: remove double blank lines
...
Fix checkpatch warning "CHECK: Please don't use multiple blank lines"
on upc.h
Signed-off-by: Cesar Santos <dev.cmsantos@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-04-16 13:44:30 +02:00
Greg Kroah-Hartman
99b75a4e32
staging: add missing SPDX lines to Kconfig files
...
There are a few remaining drivers/staging/*/Kconfig files that do not
have SPDX identifiers in them. Add the correct GPL-2.0 identifier to
them to make scanning tools happy.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-04-03 11:10:15 +02:00
Briana Oursler
1bb608f231
Staging: vt6655: rxtx: Add spaces around '*'
...
Add spaces around *. Issue found with checkpatch.
Signed-off-by: Briana Oursler <briana.oursler@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-04-01 19:19:48 +02:00
Greg Kroah-Hartman
b397f82585
Merge 5.1-rc3 into staging-next
...
We want those fixes and this resolves an erofs merge conflict.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-04-01 07:49:24 +02:00
Malcolm Priestley
cc26358f89
staging: vt6655: Remove vif check from vnt_interrupt
...
A check for vif is made in vnt_interrupt_work.
There is a small chance of leaving interrupt disabled while vif
is NULL and the work hasn't been scheduled.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
CC: stable@vger.kernel.org # v4.2+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-03-29 17:25:45 +01:00
Malcolm Priestley
3b9c2f2e0e
staging: vt6655: Fix interrupt race condition on device start up.
...
It appears on some slower systems that the driver can find its way
out of the workqueue while the interrupt is disabled by continuous polling
by it.
Move MACvIntEnable to vnt_interrupt_work so that it is always enabled
on all routes out of vnt_interrupt_process.
Move MACvIntDisable so that the device doesn't keep polling the system
while the workqueue is being processed.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
CC: stable@vger.kernel.org # v4.2+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-03-26 05:54:17 +09:00
Vatsala Narang
ab2a7a292a
staging: vt6655: lines should not end with a parentheses
...
Adjust code to fix the style issue-lines should not end with a
parentheses
Signed-off-by: Vatsala Narang <vatsalanarang@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-03-26 05:42:37 +09:00
Ganesh Biradar
03f4a7b688
staging: vt6655: Modify comment style of SPDX License Identifier
...
Fix the comment style of SPDX license identifier based on header file
type
Signed-off-by: Ganesh Biradar <grbesd1@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-03-26 05:41:28 +09:00