Johannes Berg
81f153faac
staging: rtl8723bs: fix wireless regulatory API misuse
...
This code ends up calling wiphy_apply_custom_regulatory(), for which
we document that it should be called before wiphy_register(). This
driver doesn't do that, but calls it from ndo_open() with the RTNL
held, which caused deadlocks.
Since the driver just registers static regdomain data and then the
notifier applies the channel changes if any, there's no reason for
it to call this in ndo_open(), move it earlier to fix the deadlock.
Reported-and-tested-by: Hans de Goede <hdegoede@redhat.com >
Fixes: 51d62f2f2c ("cfg80211: Save the regulatory domain with a lock")
Link: https://lore.kernel.org/r/20210126115409.d5fd6f8fe042.Ib5823a6feb2e2aa01ca1a565d2505367f38ad246@changeid
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
Signed-off-by: Johannes Berg <johannes.berg@intel.com >
2021-01-26 12:21:42 +01:00
Ross Schmidt
8764c27fbd
staging: rtl8723bs: remove ELEMENT_ID enum
...
The ELEMENT_ID enum is no longer used, remove it.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-22-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:52 +01:00
Ross Schmidt
a228b40195
staging: rtl8723bs: remove unused macros
...
Remove many macros from wifi.h and ieee80211.h because they are unused.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-21-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
5b45010f2e
staging: rtl8723bs: replace EID_EXTCapability
...
Replace unique EID_EXTCapability constant with kernel provided
WLAN_EID_EXT_CAPABILITY from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-20-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
d7ca2c3d2d
staging: rtl8723bs: replace EID_BSSIntolerantChlReport
...
Replace unique EID_BSSIntolerantChlReport constant with kernel provided
WLAN_EID_BSS_INTOLERANT_CHL_REPORT from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-19-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
9b5d8c1fe1
staging: rtl8723bs: replace EID_BSSCoexistence
...
Replace unique EID_BSSCoexistence constant with kernel provided
WLAN_EID_BSS_COEX_2040 from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-18-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
99bb776980
staging: rtl8723bs: replace _MME_IE_
...
Replace unique _MME_IE_ macro with kernel provided WLAN_EID_MMIE from
linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-17-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
fc41e9618f
staging: rtl8723bs: replace _WAPI_IE_
...
Replace unique _WAPI_IE_ macro with kernel provided
WLAN_EID_BSS_AC_ACCESS_DELAY from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-16-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
00f0b68284
staging: rtl8723bs: replace _EXT_SUPPORTEDRATES_IE_
...
Replace unique _EXT_SUPPORTEDRATES_IE_ macro with kernel provided
WLAN_EID_EXT_SUPP_RATES from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-15-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
7bd332ec5e
staging: rtl8723bs: replace _ERPINFO_IE_
...
Replace unique _ERPINFO_IE_ macro with kernel provided WLAN_EID_ERP_INFO
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-14-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
38caee0abe
staging: rtl8723bs: replace _CHLGETXT_IE_
...
Replace unique _CHLGETXT_IE_ macro with kernel provided WLAN_EID_CHALLENGE
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-13-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
0b44fca943
staging: rtl8723bs: replace _COUNTRY_IE_
...
Replace unique _COUNTRY_IE_ macro with kernel provided WLAN_EID_COUNTRY
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-12-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
e6038a488c
staging: rtl8723bs: replace _IBSS_PARA_IE_
...
Replace unique _IBSS_PARA_IE_ macro with kernel provided
WLAN_EID_IBSS_PARAMS from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-11-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
aaa0bc19fa
staging: rtl8723bs: replace _TIM_IE_
...
Replace unique _TIM_IE_ macro with kernel provided WLAN_EID_DS_PARAMS
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-10-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:51 +01:00
Ross Schmidt
8f6a9446c6
staging: rtl8723bs: replace _DSSET_IE_
...
Replace unique _DSSET_IE_ macro with kernel provdied WLAN_EID_DS_PARAMS
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-9-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
c34c45ed98
staging: rtl8723bs: replace _SUPPORTEDRATES_IE_
...
Replace unique _SUPPORTEDRATES_IE_ macro with kernel provided
WLAN_EID_SUPP_RATES from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-8-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
3f15277b29
staging: rtl8723bs: replace _SSID_IE_
...
Replace unique _SSID_IE_ macro with kernel provided WLAN_EID_SSID from
linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-7-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
b03da03a26
staging: rtl8723bs: replace WLAN_EID_VHT_OP_MODE_NOTIFY
...
Replace unique WLAN_EID_VHT_OP_MODE_NOFITY macro with kernel provided
WLAN_EID_OPMODE_NOTIF from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-6-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
332ec9db09
staging: rtl8723bs: use WLAN_EID_HT_OPERATION
...
Replace unique _HT_EXTRA_INFO_IE_ and _HT_ADD_INFO_IE_ macros with kernel
provided WLAN_EID_HT_OPERATION from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-5-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
3359e2927b
staging: rtl8723bs: use WLAN_EID_RSN
...
Replace unique _WPA2_IE_ID_, EID_WPA2, and _RSN_IE_2_ with kernel provided
WLAN_EID_RSN from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-4-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
b05cc3a915
staging: rtl8723bs: use WLAN_EID_VENDOR_SPECIFIC
...
Replace unique WLAN_EID_GENERIC, _WPA_IE_ID_, _SSN_IE_1_, and
_VENDOR_SPECIFIC_IE_ macros with kernel provided WLAN_EID_VENDOR_SPECIFIC
from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-3-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
fc6a65288c
staging: rtl8723bs: use WLAN_EID_HT_CAPABILITY
...
Replace unique WLAN_EID_HT_CAP, _HT_CAPABILITY_IE_, and EID_HTCapability
with kernel provided WLAN_EID_HT_CAPABILITY from linux/ieee80211.h.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201208040733.379197-2-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-08 09:55:50 +01:00
Ross Schmidt
19cf9d7afc
staging: rtl8723bs: remove LIST_CONTAINOR
...
Remove unnecessary macro for container_of and call it directly.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-9-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
4cd8898174
staging: rtl8723bs: remove unused macros
...
Remove many macros from wifi.h because they are unused.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-8-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
b3ae8af6a7
staging: rtl8723bs: replace RTW_IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK
...
Replace unique macro RTW_IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK with kernel
provided IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK. The other
IEEE80211_ADDBA_* and IEEE_DELBA_* macros are duplicates already defined
in linux/ieee80211.h, remove them.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-7-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
2841fa62e2
staging: rtl8723bs: remove WLAN_HT_CAP_SM_PS_* macros
...
The WLAN_HT_CAP_SM_PS_* macro family is already defined in
linux/ieee80211.h, remove them.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-6-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
ac74ae7671
staging: rtl8723bs: replace OP_MODE_* and HT_INFO_OPERATION_MODE_* macros
...
Replace unique OP_MODE_* and HT_INFO_OPERATION_MODE_* macro families
with kernel provided IEEE80211_HT_OP_MODE_* macros.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-5-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
98b32c71a4
staging: rtl8723bs: replace HT_CAP_AMPDU_FACTOR
...
Replace unique HT_CAP_AMPDU_FACTOR enum with kernel provided
ieee80211_max_ampdu_length_exp enum.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-4-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
2415ae7fa2
staging: rtl8723bs: replace cap_* macros
...
Replace unique cap_* macros with kernel provided WLAN_CAPABILITY_*
macros.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-3-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
5ed3e6f29f
staging: rtl8723bs: replace WIFI_REASON_CODE
...
Replace unique macros and WIFI_REASON_CODE enum with the kernel provided
ieee80211_reasoncode.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-2-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Ross Schmidt
6d75b5044b
staging: rtl8723bs: replace unique macros and WIFI_STATUS_CODE
...
Replace many unique macros and WIFI_STATUS_CODE enum with kernel
provided ieee80211_statuscode. A duplicate
WLAN_STATUS_ASSOC_DENIED_NOSHORT macro is also removed.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201206034517.4276-1-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:12:40 +01:00
Brother Matthew De Angelis
6c7b8ac995
Staging: rtl8723bs/core: add blank line after declarations
...
Fix coding style issue.
Add blank line after variable declarations at all the locations found by
checkpatch.pl.
Signed-off-by: Brother Matthew De Angelis <matthew.v.deangelis@gmail.com >
Link: https://lore.kernel.org/r/20201206025945.GA464875@a
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:09:16 +01:00
Brother Matthew De Angelis
954c647ace
Staging: rtl8723bs/core: fix brace coding style issue
...
Remove unnecessary braces identified by checkpatch.pl at lines 740,
1039,1602,1922,1939.
Signed-off-by: Brother Matthew De Angelis <matthew.v.deangelis@gmail.com >
Link: https://lore.kernel.org/r/8ddd195a246696e9315dacfcce06b7ba7f9d7d1a.1607209336.git.matthew.v.deangelis@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:08:28 +01:00
Brother Matthew De Angelis
be25cfd80e
Staging: rtl8723bs/core: delete empty if statement
...
Delete an if statement that was not executing anything when true.
This has the side effect of removing one checkpatch warning about braces
not being necessary.
Signed-off-by: Brother Matthew De Angelis <matthew.v.deangelis@gmail.com >
Link: https://lore.kernel.org/r/1895dc8a7b44bfdcb6a46273703fabad80cbdf99.1607209336.git.matthew.v.deangelis@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-07 15:08:28 +01:00
Brother Matthew De Angelis
138f3e1265
Staging: rtl8723bs/core fix brace coding style issues in rtw_ioctl_set.c
...
Fix all the brace code style warnings found by the checkpatch tool at the following lines:
rtw_ioctl_set.c:178: WARNING: braces {} are not necessary for any arm of this statement
rtw_ioctl_set.c:219: WARNING: braces {} are not necessary for any arm of this statement
rtw_ioctl_set.c:255: WARNING: braces {} are not necessary for any arm of this statement
rtw_ioctl_set.c:324: WARNING: braces {} are not necessary for any arm of this statement
rtw_ioctl_set.c:372: WARNING: braces {} are not necessary for any arm of this statement
rtw_ioctl_set.c:396: WARNING: braces {} are not necessary for any arm of this statement
rtw_ioctl_set.c:441: WARNING: braces {} are not necessary for single statement blocks
rtw_ioctl_set.c:527: WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Brother Matthew De Angelis <matthew.v.deangelis@gmail.com >
Link: https://lore.kernel.org/r/20201203025836.GA420974@a
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-12-04 16:45:55 +01:00
Kaixu Xia
8a3f7b9665
staging: rtl8723bs: remove redundant statements
...
The bool variable is2T is true, so the if statement is redundant.
we can directly set the variable bound to 8 and remove the if
statement.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com >
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com >
Link: https://lore.kernel.org/r/1605961041-12875-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-23 17:59:52 +01:00
Gustavo A. R. Silva
2811861be7
staging: rtl8723bs: core: Fix fall-through warnings for Clang
...
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
Link: https://lore.kernel.org/r/cd07e3ebc11b44a3fe016341438e24cf950994a3.1605896059.git.gustavoars@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-23 17:55:22 +01:00
Greg Kroah-Hartman
03c1136af5
Merge 5.10-rc5 into staging-testing
...
We want the staging/IIO fixes in here as well.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-23 08:21:37 +01:00
Ross Schmidt
39439d7155
staging: rtl8723bs: clean up leading space
...
Convert spaces to tabs to fix coding style issues and clear checkpatch
warnings.
WARNING: please, no spaces at the start of a line
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-10-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:54 +01:00
Ross Schmidt
cad33240ab
staging: rtl8723bs: clean up pointer locations
...
Move pointer locations to fix coding style issues and clear checkpatch
errors.
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-9-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
8ec06b9ff8
staging: rtl8723bs: clean up logical continuations
...
Move operators to fix coding style issues and clear checkpatch checks.
CHECK: Logical continuations should be on the previous line
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-8-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
cf05a0086e
staging: rtl8723bs: clean up trailing statements
...
Move trailing statements to the next line to fix coding style issues and
clear checkpatch errors.
ERROR: trailing statements should be on next line
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-7-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
5ddd99756c
staging: rtl8723bs: clean up switch case indentation
...
Move cases to align with switch indentation to fix coding style issues
and clear checkpatch errors.
ERROR: switch and case should be at the same indent
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-6-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
fa7c458672
staging: rtl8723bs: clean up open braces
...
Move braces to fix coding style issues and clear checkpatch errors.
Some braces are removed for single statements.
ERROR: open brace '{' following function definitions go on the next line
ERROR: that open brace { should be on the previous line
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-5-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
5641eeec0f
staging: rtl8723bs: clean up open ended lines
...
Move declarations to fix coding style issues and clear checkpatch
checks.
CHECK: Lines should not end with a '('
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-4-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
79008395e5
staging: rtl8723bs: clean up space before tabs
...
Remove spaces before tabs to fix coding style issues and clear
checkpatch warnings.
WARNING: please, no space before tabs
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-3-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
70466c39ba
staging: rtl8723bs: clean up braces
...
Add or remove braces or remove lines to fix coding style issues and
clear checkpatch.
WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
CHECK: Unbalanced braces around else statement
CHECK: braces {} should be used on all arms of this statement
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-2-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Ross Schmidt
2204571256
staging: rtl8723bs: clean up line spacing
...
Add or remove lines to fix coding style issues and clear checkpatch.
WARNING: Missing a blank line after declarations
CHECK: Please use a blank line after function/struct/union/enum declarations
CHECK: Please don't use multiple blank lines
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201110041008.15847-1-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-13 16:25:53 +01:00
Brian O'Keefe
aee9dccc5b
staging: rtl8723bs: Add 024c:0627 to the list of SDIO device-ids
...
Add 024c:0627 to the list of SDIO device-ids, based on hardware found in
the wild. This hardware exists on at least some Acer SW1-011 tablets.
Signed-off-by: Brian O'Keefe <bokeefe@alum.wpi.edu >
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Link: https://lore.kernel.org/r/b9e1523f-2ba7-fb82-646a-37f095b4440e@alum.wpi.edu
Cc: stable <stable@vger.kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-06 17:06:29 +01:00
Ross Schmidt
f4acd33c44
staging: rtl8723bs: replace ieee80211_back_actioncode
...
Replace the unique rtw_ieee80211_back_actioncode with the standard
provided ieee80211_back_actioncode.
Signed-off-by: Ross Schmidt <ross.schm.dev@gmail.com >
Link: https://lore.kernel.org/r/20201105034754.12383-9-ross.schm.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2020-11-06 11:05:52 +01:00