Uwe Kleine-König
f62e3f595c
interconnect: imx: Make imx_icc_unregister() return void
...
The function imx_icc_unregister() returns zero unconditionally. Make it
return void.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Link: https://lore.kernel.org/r/20220718121409.171773-9-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-08-18 07:20:41 +03:00
Uwe Kleine-König
7ec26b8dcc
interconnect: imx: Ignore return value of icc_provider_del() in .remove()
...
icc_provider_del() already emits an error message on failure. In this
case letting .remove() return the corresponding error code results in
another error message and the device is removed anyhow. (See
platform_remove().)
So ignore the return value of icc_provider_del() and return 0
unconditionally.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Link: https://lore.kernel.org/r/20220718121409.171773-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-08-16 16:37:36 +03:00
Peng Fan
c14ec5c93d
interconnect: imx: Add platform driver for imx8mp
...
Add a platform driver for the i.MX8MP SoC describing bus topology, based
on internal documentation.
Signed-off-by: Peng Fan <peng.fan@nxp.com >
Link: https://lore.kernel.org/r/20220703091132.1412063-9-peng.fan@oss.nxp.com
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-07-15 17:53:15 +03:00
Peng Fan
7980d85a94
interconnect: imx: configure NoC mode/prioriry/ext_control
...
Introduce imx_icc_noc_setting structure to describe a master port setting
Pass imx_icc_noc_setting as a parameter from specific driver
Set priority level, mode, ext control in imx_icc_node_set
Signed-off-by: Peng Fan <peng.fan@nxp.com >
Link: https://lore.kernel.org/r/20220703091132.1412063-8-peng.fan@oss.nxp.com
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-07-15 17:53:15 +03:00
Peng Fan
12db59e8e0
interconnect: imx: introduce imx_icc_provider
...
Introduce imx_icc_provider as a wrapper of icc_provider to
add i.MX specific information.
Signed-off-by: Peng Fan <peng.fan@nxp.com >
Link: https://lore.kernel.org/r/20220703091132.1412063-7-peng.fan@oss.nxp.com
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-07-15 17:53:15 +03:00
Peng Fan
6eeaf28c79
interconnect: imx: set src node
...
When set QoS for a icc path, only set dst icc node is not enough,
also need to set src icc node.
Signed-off-by: Peng Fan <peng.fan@nxp.com >
Link: https://lore.kernel.org/r/20220703091132.1412063-6-peng.fan@oss.nxp.com
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-07-15 17:53:15 +03:00
Peng Fan
bd734481e1
interconnect: imx: fix max_node_id
...
max_node_id not equal to the ARRAY_SIZE of node array, need increase 1,
otherwise xlate will fail for the last entry. And rename max_node_id
to num_nodes to reflect the reality.
Fixes: f0d8048525 ("interconnect: Add imx core driver")
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com >
Signed-off-by: Peng Fan <peng.fan@nxp.com >
Link: https://lore.kernel.org/r/20220703091132.1412063-5-peng.fan@oss.nxp.com
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-07-15 17:53:04 +03:00
Abel Vesa
9d6c7ee7c4
interconnect: imx: Add imx_icc_get_bw function to set initial avg and peak
...
Set the initial avg and peak to 0 in order to avoid setting them to
INT_MAX by the interconnect core.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com >
Link: https://lore.kernel.org/r/20220106170501.3513423-1-abel.vesa@nxp.com
Signed-off-by: Georgi Djakov <djakov@kernel.org >
2022-01-23 23:32:48 +02:00
Martin Kepplinger
67288f74d4
interconnect: imx8mq: Use icc_sync_state
...
Add the icc_sync_state callback to notify the framework when consumers
are probed and the bandwidth doesn't have to be kept at maximum anymore.
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm >
Suggested-by: Georgi Djakov <georgi.djakov@linaro.org >
Fixes: 7d3b0b0d81 ("interconnect: qcom: Use icc_sync_state")
Link: https://lore.kernel.org/r/20201210100906.18205-6-martin.kepplinger@puri.sm
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-12-28 14:03:02 +02:00
Christophe JAILLET
6414b79d02
interconnect: imx: Remove a useless test
...
'dn' can't be NULL here, it is tested just the line above.
Remove this useless test.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr >
Link: https://lore.kernel.org/r/20201206121322.29434-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-12-28 14:03:02 +02:00
Christophe JAILLET
c6174c0e05
interconnect: imx: Add a missing of_node_put after of_device_is_available
...
Add an 'of_node_put()' call when a tested device node is not available.
Fixes: f0d8048525 ("interconnect: Add imx core driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr >
Link: https://lore.kernel.org/r/20201206121304.29381-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-12-28 14:03:02 +02:00
Liu Shixin
86d6e5793e
interconnect: imx: simplify the return expression of imx_icc_unregister
...
Simplify the return expression.
Signed-off-by: Liu Shixin <liushixin2@huawei.com >
Link: https://lore.kernel.org/r/20200921082437.2591461-1-liushixin2@huawei.com
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-09-21 11:15:02 +03:00
Krzysztof Kozlowski
e0cbf2f0a7
interconnect: imx: Simplify with dev_err_probe()
...
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org >
Link: https://lore.kernel.org/r/20200902172433.1138-2-krzk@kernel.org
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-09-18 09:55:12 +03:00
Wei Yongjun
360a10285e
interconnect: imx: Fix return value check in imx_icc_node_init_qos()
...
In case of error, the function of_parse_phandle() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.
Fixes: f0d8048525 ("interconnect: Add imx core driver")
Reported-by: Hulk Robot <hulkci@huawei.com >
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com >
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com >
Link: https://lore.kernel.org/r/20200509030214.14435-1-weiyongjun1@huawei.com
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-05-10 18:30:37 +03:00
Leonard Crestez
4b54bf4763
interconnect: imx: Add platform driver for imx8mn
...
Add a platform driver for the i.MX8MN SoC describing bus topology, based
on internal documentation.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com >
Link: https://lore.kernel.org/r/338a5409ce88811ba6c940ba06441db3faa8c187.1586174566.git.leonard.crestez@nxp.com
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-04-28 20:03:02 +03:00
Leonard Crestez
63fc8029b3
interconnect: imx: Add platform driver for imx8mq
...
Add a platform driver for the i.MX8MQ SoC describing bus topology,
based on internal documentation.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com >
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm >
Link: https://lore.kernel.org/r/864310d1f2599c3bd621e70b77028a6e89f6410e.1586174566.git.leonard.crestez@nxp.com
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-04-28 20:03:02 +03:00
Leonard Crestez
2c1966af07
interconnect: imx: Add platform driver for imx8mm
...
Add a platform driver for the i.MX8MM SoC describing bus topology.
Bandwidth adjustments is currently only supported on the DDRC and main
NOC. Scaling for the vpu/gpu/display NICs could be added in the future.
Signed-off-by: Alexandre Bailon <abailon@baylibre.com >
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com >
Link: https://lore.kernel.org/r/b14eef179dbd837a486619724b8033490f49db72.1586174566.git.leonard.crestez@nxp.com
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-04-28 20:03:02 +03:00
Leonard Crestez
f0d8048525
interconnect: Add imx core driver
...
This adds support for i.MX SoC family to interconnect framework.
Platform drivers can describe the interconnect graph and several
adjustment knobs where icc node bandwidth is converted to a
DEV_PM_QOS_MIN_FREQUENCY request.
The interconnect provider is probed through the main NOC device and
other adjustable nodes on the same graph are found from a
fsl,scalable-nodes phandle array property.
Signed-off-by: Alexandre Bailon <abailon@baylibre.com >
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com >
Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm >
Link: https://lore.kernel.org/r/35920e673df6c04cbbb7d877a7d4ba25fd91a784.1586174566.git.leonard.crestez@nxp.com
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org >
2020-04-28 20:03:02 +03:00