Jiapeng Chong
1fcbe4c490
scsi: mpi3mr: Fix kernel-doc
...
Fix the following W=1 kernel warnings:
drivers/scsi/mpi3mr/mpi3mr_app.c:1706: warning: expecting prototype for
adapter_state_show(). Prototype was for adp_state_show() instead.
Link: https://lore.kernel.org/r/20220525093514.55467-1-jiapeng.chong@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com >
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-06-01 22:43:26 -04:00
Sumit Saxena
4094981db7
scsi: mpi3mr: Rework mrioc->bsg_device model to fix warnings
...
During driver unload, mrioc->bsg_device reference count becomes
negative. Also, as reported in [1], the driver's bsg_device model had few
more bugs. Fix all these up.
[1] https://marc.info/?l=linux-scsi&m=165183971411991&w=2
Link: https://lore.kernel.org/r/20220526170157.58274-1-sumit.saxena@broadcom.com
Fixes: 4268fa7513dan.carpenter@oracle.com >
Tested-by: Tomas Henzl <thenzl@redhat.com >
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-06-01 22:23:09 -04:00
Sreekanth Reddy
9feb5c4c3f
scsi: mpi3mr: Add target device related sysfs attributes
...
Add sysfs attributes for exposing target device details such as SAS
address, firmware device handle, and persistent ID for the
controller-attached devices and RAID volumes.
Link: https://lore.kernel.org/r/20220517115310.13062-3-sreekanth.reddy@broadcom.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-19 20:16:26 -04:00
Sreekanth Reddy
e51e76eddd
scsi: mpi3mr: Add shost related sysfs attributes
...
Add shost related sysfs attributes to display the controller's firmware
version, queue depth, number of requests, and number of reply queues. Also
add an attribute to set & get the logging_level.
Link: https://lore.kernel.org/r/20220517115310.13062-2-sreekanth.reddy@broadcom.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-19 20:16:26 -04:00
Dan Carpenter
a25eafd13e
scsi: mpi3mr: Fix a NULL vs IS_ERR() bug in mpi3mr_bsg_init()
...
The bsg_setup_queue() function does not return NULL. It returns error
pointers. Fix the check accordingly.
Link: https://lore.kernel.org/r/YnUf7RQl+A3tigWh@kili
Fixes: 4268fa7513dan.carpenter@oracle.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-16 21:30:17 -04:00
Sumit Saxena
7dbd0dd8cd
scsi: mpi3mr: Add support for NVMe passthrough
...
Add support for management applications to send an MPI3 Encapsulated NVMe
passthru command to the NVMe devices attached to an Avenger controller.
Since the NVMe drives are exposed as SCSI devices by the controller, the
standard NVMe applications cannot be used to interact with the drives and
the command sets supported are also limited by the controller firmware.
Special handling is required for MPI3 Encapsulated NVMe passthru commands
for PRP/SGL setup in the commands.
Link: https://lore.kernel.org/r/20220429211641.642010-8-sumit.saxena@broadcom.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-02 17:02:42 -04:00
Sumit Saxena
986d6bad21
scsi: mpi3mr: Expose adapter state to sysfs
...
Link: https://lore.kernel.org/r/20220429211641.642010-7-sumit.saxena@broadcom.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-02 17:02:42 -04:00
Sumit Saxena
43ca110050
scsi: mpi3mr: Add support for PEL commands
...
Implement driver support for management applications to enable persistent
event log (PEL) notifications. Upon receipt of events, the driver will
increment a sysfs variable named event_counter. The management application
will poll for event_counter value changes and signal the application about
events.
Link: https://lore.kernel.org/r/20220429211641.642010-6-sumit.saxena@broadcom.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-02 17:02:42 -04:00
Sumit Saxena
506bc1a0d6
scsi: mpi3mr: Add support for MPT commands
...
There are certain management commands which require firmware intervention.
These commands are termed MPT commands. Add support for them.
Link: https://lore.kernel.org/r/20220429211641.642010-5-sumit.saxena@broadcom.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-02 17:02:42 -04:00
Sumit Saxena
f5e6d5a343
scsi: mpi3mr: Add support for driver commands
...
There are certain bsg commands which need to be completed by the driver
without involving firmware. These requests are termed driver commands. Add
support for these.
Link: https://lore.kernel.org/r/20220429211641.642010-3-sumit.saxena@broadcom.com
Reported by: Stephen Rothwell <sfr@canb.auug.org.au >
Reported-by: kernel test robot <lkp@intel.com >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-02 17:02:41 -04:00
Sumit Saxena
4268fa7513
scsi: mpi3mr: Add bsg device support
...
Create bsg device per controller for controller management purposes.
bsg device nodes will be named /dev/bsg/mpi3mrctl0, /dev/bsg/mpi3mrctl1,
etc.
Link: https://lore.kernel.org/r/20220429211641.642010-2-sumit.saxena@broadcom.com
Reported-by: kernel test robot <lkp@intel.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com >
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com >
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com >
2022-05-02 17:02:41 -04:00
