Alistair Francis
fafc66387d
Input: wacom_i2c - clean up the query device fields
...
Improve the query device fields to be more verbose.
Signed-off-by: Alistair Francis <alistair@alistair23.me >
Link: https://lore.kernel.org/r/20211118123545.102872-1-alistair@alistair23.me
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2021-11-29 00:15:39 -08:00
Alistair Francis
91e2e76695
Input: wacom_i2c - use macros for the bit masks
...
To make the code easier to read use macros for the bit masks.
Signed-off-by: Alistair Francis <alistair@alistair23.me >
Link: https://lore.kernel.org/r/20211009113707.17568-2-alistair@alistair23.me
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2021-11-09 22:52:07 -08:00
Dmitry Torokhov
c75cf86201
Input: wacom_i2c - switch to using managed resources
...
This simplifies error unwinding path and allows us to get rid of
remove() method.
Reviewed-by: Alistair Francis <alistair@alistair23.me >
Link: https://lore.kernel.org/r/20210321220043.318239-2-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2021-03-25 11:14:09 -07:00
Dmitry Torokhov
b6621f72cc
Input: wacom_i2c - do not force interrupt trigger
...
Instead of forcing interrupt trigger to "level low" rely on the
platform to set it up according to how it is wired on the given
board.
Reviewed-by: Alistair Francis <alistair@alistair23.me >
Link: https://lore.kernel.org/r/20210321220043.318239-1-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2021-03-25 11:14:09 -07:00
Fabio Estevam
78e45917bf
Input: wacom_i2c - remove unneeded gpio.h header file
...
There is no gpio functions used in the driver that is exported
by the gpio.h header, so remove this unneeded header.
Signed-off-by: Fabio Estevam <festevam@gmail.com >
Link: https://lore.kernel.org/r/20191026185958.24158-3-festevam@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2019-10-27 11:14:25 -07:00
Thomas Gleixner
83cde38357
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 55
...
Based on 1 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license as published by
the free software foundation either version of 2 of the license or
at your option any later version
extracted by the scancode license scanner the SPDX license identifier
GPL-2.0-or-later
has been chosen to replace the boilerplate/reference in 4 file(s).
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Reviewed-by: Richard Fontana <rfontana@redhat.com >
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org >
Reviewed-by: Allison Randal <allison@lohutok.net >
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190520071858.207758043@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-05-24 17:36:42 +02:00
Krzysztof Kozlowski
800e3b9a68
Input: drop owner assignment from i2c_driver
...
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2015-07-17 16:57:00 -07:00
Jingoo Han
02b6a58b83
Input: touchscreen - use __maybe_unused instead of ifdef around suspend/resume
...
Use __maybe_unused instead of ifdef guards around suspend/resume
functions, in order to increase build coverage and fix build warnings.
Signed-off-by: Jingoo Han <jg1.han@samsung.com >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2014-11-02 00:10:07 -07:00
Tatsunosuke Tobita
8855f30cd2
Input: wacom_i2c - implement hovering capability
...
Although BTN_TOOL_PEN and BTN_TOOL_RUBBER functioned properly, the driver
didn't have hover functionality, so it's been added.
Also, "WACOM_RETRY_CNT" was not used, so it was removed.
Signed-off-by: Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2013-06-18 23:19:00 -07:00
Bill Pemberton
e2619cf78e
Input: remove use of __devexit
...
CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2012-11-24 00:05:38 -08:00
Bill Pemberton
5298cc4cc7
Input: remove use of __devinit
...
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com >
Acked-by: Javier Martinez Canillas <javier@dowhile0.org >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2012-11-24 00:05:19 -08:00
Bill Pemberton
1cb0aa8817
Input: remove use of __devexit_p
...
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2012-11-24 00:03:48 -08:00
Dmitry Torokhov
8830cb88dd
Input: wacom_i2c - fix compiler warning
...
Apparently GCC can't figure out that we bail if we fail to query device
and will not try to use 'features':
drivers/input/touchscreen/wacom_i2c.c: In function ‘wacom_i2c_probe’:
drivers/input/touchscreen/wacom_i2c.c:177:20: warning: ‘features.fw_version’
may be used uninitialized in this function [-Wmaybe-uninitialized]
Signed-off-by: Dmitry Torokhov <dtor@mail.ru >
2012-07-07 16:41:12 -07:00
Dmitry Torokhov
d568778298
Input: wacom_i2c - do not use irq_to_gpio
...
Because irq_to_gpio() is not available on many platforms let's switch
to level-triggered one-shot IRQs that will stay active as long as
there is data to be read.
Tested-by: Tobita Tatsunosuke <tobita.tatsunosuke@wacom.co.jp >
Signed-off-by: Dmitry Torokhov <dtor@mail.ru >
2012-04-10 00:42:15 -07:00
Tatsunosuke Tobita
5a966261c0
Input: add support for Wacom Stylus device with I2C interface
...
This adds support for Wacom Stylus device with I2C interface.
[Dan Carpenter <dan.carpenter@oracle.com >: fix NULL-pointer dereference
in error handling path.]
Signed-off-by: Tatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp >
Signed-off-by: Dmitry Torokhov <dtor@mail.ru >
2012-04-04 09:24:23 -07:00