leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

e1000e: Correct NVM checksum verification flow

Browse Source 
Update MAC type check e1000_pch_tgp because for e1000_pch_cnp,
NVM checksum update is still possible.
Emit a more detailed warning message.

Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1191663
Fixes: 4051f68318 ("e1000e: Do not take care about recovery NVM checksum")
Reported-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
This commit is contained in:
Sasha Neftin
2022-02-03 14:21:49 +02:00
committed by Tony Nguyen
parent 1866aa0d0d
commit ffd24fa2fc
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/intel/e1000e/ich8lan.c
View File

@@ -4140,9 +4140,9 @@ static s32 e1000_validate_nvm_checksum_ich8lan(struct e1000_hw *hw)
return ret_val; return ret_val;
if (!(data & valid_csum_mask)) { if (!(data & valid_csum_mask)) {
e_dbg("NVM Checksum Invalid\n"); e_dbg("NVM Checksum valid bit not set\n");
if (hw->mac.type < e1000_pch_cnp) { if (hw->mac.type < e1000_pch_tgp) {
data |= valid_csum_mask; data |= valid_csum_mask;
ret_val = e1000_write_nvm(hw, word, 1, &data); ret_val = e1000_write_nvm(hw, word, 1, &data);
if (ret_val) if (ret_val)