[PATCH] ppc64: bugfix: crash on PHB add

19-rpaphp-crashing.patch

This patch fixes a bug related to dlpar PHB add, after a PHB removal.

-- The crash was due to the PHB not having a pci_dn structure yet,
   when the phb is being added.

This code survived testing, of adding and removeig the PHB and all slots
underneath it, 17 times so far, as of this writing.

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Linas Vepstas 2005-11-03 18:51:17 -06:00 committed by Paul Mackerras
parent d9564ad114
commit fe98aeab84

View File

@ -306,7 +306,7 @@ static int dlpar_add_phb(char *drc_name, struct device_node *dn)
{ {
struct pci_controller *phb; struct pci_controller *phb;
if (PCI_DN(dn)->phb) { if (PCI_DN(dn) && PCI_DN(dn)->phb) {
/* PHB already exists */ /* PHB already exists */
return -EINVAL; return -EINVAL;
} }