leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lightnvm: pblk: add lock protection to list operations

Browse Source 
Protect the list_add on the pblk_line_init_bb() error
path in case this code is used for some other purpose
in the future.

Signed-off-by: Hua Su <suhua.tanke@gmail.com>
Reviewed-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Hua Su
2018-12-11 20:16:18 +01:00
committed by Jens Axboe
parent 6e82f0ba00
commit fde201a466
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/lightnvm/pblk-core.c
View File

@@ -1295,15 +1295,22 @@ int pblk_line_recov_alloc(struct pblk *pblk, struct pblk_line *line)
ret = pblk_line_alloc_bitmaps(pblk, line); ret = pblk_line_alloc_bitmaps(pblk, line);
if (ret) if (ret)
return ret; goto fail;
if (!pblk_line_init_bb(pblk, line, 0)) { if (!pblk_line_init_bb(pblk, line, 0)) {
list_add(&line->list, &l_mg->free_list); ret = -EINTR;
return -EINTR; goto fail;
} }
pblk_rl_free_lines_dec(&pblk->rl, line, true); pblk_rl_free_lines_dec(&pblk->rl, line, true);
return 0; return 0;
fail:
spin_lock(&l_mg->free_lock);
list_add(&line->list, &l_mg->free_list);
spin_unlock(&l_mg->free_lock);
return ret;
} }
void pblk_line_recov_close(struct pblk *pblk, struct pblk_line *line) void pblk_line_recov_close(struct pblk *pblk, struct pblk_line *line)