leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

basic_mmio_gpio: convert to non-__raw* accessors

Browse Source 
The __raw_* accessors don't include memory barriers and can cause
problems when writes get stuck in write buffers.

Suggested-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
Jamie Iles 2011-05-20 00:40:17 -06:00 committed by Grant Likely
parent 31029116eb
commit fd99623521
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/gpio/basic_mmio_gpio.c
View File

@ -101,43 +101,43 @@ static struct bgpio_chip *to_bgpio_chip(struct gpio_chip *gc)
static void bgpio_write8(void __iomem *reg, unsigned long data) static void bgpio_write8(void __iomem *reg, unsigned long data)
{ {
__raw_writeb(data, reg); writeb(data, reg);
} }
static unsigned long bgpio_read8(void __iomem *reg) static unsigned long bgpio_read8(void __iomem *reg)
{ {
return __raw_readb(reg); return readb(reg);
} }
static void bgpio_write16(void __iomem *reg, unsigned long data) static void bgpio_write16(void __iomem *reg, unsigned long data)
{ {
__raw_writew(data, reg); writew(data, reg);
} }
static unsigned long bgpio_read16(void __iomem *reg) static unsigned long bgpio_read16(void __iomem *reg)
{ {
return __raw_readw(reg); return readw(reg);
} }
static void bgpio_write32(void __iomem *reg, unsigned long data) static void bgpio_write32(void __iomem *reg, unsigned long data)
{ {
__raw_writel(data, reg); writel(data, reg);
} }
static unsigned long bgpio_read32(void __iomem *reg) static unsigned long bgpio_read32(void __iomem *reg)
{ {
return __raw_readl(reg); return readl(reg);
} }
#if BITS_PER_LONG >= 64 #if BITS_PER_LONG >= 64
static void bgpio_write64(void __iomem *reg, unsigned long data) static void bgpio_write64(void __iomem *reg, unsigned long data)
{ {
__raw_writeq(data, reg); writeq(data, reg);
} }
static unsigned long bgpio_read64(void __iomem *reg) static unsigned long bgpio_read64(void __iomem *reg)
{ {
return __raw_readq(reg); return readq(reg);
} }
#endif /* BITS_PER_LONG >= 64 */ #endif /* BITS_PER_LONG >= 64 */