leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Smack: fix behavior of smack_inode_listsecurity

Browse Source 
Security operation ->inode_listsecurity is used for generating list of
available extended attributes for syscall listxattr. Currently it's used
only in nfs4 or if filesystem doesn't provide i_op->listxattr.

The list is the set of NULL-terminated names, one after the other.
This method must include zero byte at the and into result.

Also this function must return length even if string does not fit into
output buffer or it is NULL, see similar method in selinux and man listxattr.

Signed-off-by: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
This commit is contained in:
Konstantin Khlebnikov 2014-08-07 20:52:33 +04:00 committed by Casey Schaufler
parent 478d085524
commit fd5c9d230d
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
security/smack/smack_lsm.c
View File

@ -1122,13 +1122,12 @@ static int smack_inode_getsecurity(const struct inode *inode,
static int smack_inode_listsecurity(struct inode *inode, char *buffer, static int smack_inode_listsecurity(struct inode *inode, char *buffer,
size_t buffer_size) size_t buffer_size)
{ {
int len = strlen(XATTR_NAME_SMACK); int len = sizeof(XATTR_NAME_SMACK);
if (buffer != NULL && len <= buffer_size) { if (buffer != NULL && len <= buffer_size)
memcpy(buffer, XATTR_NAME_SMACK, len); memcpy(buffer, XATTR_NAME_SMACK, len);
return len;
} return len;
return -EINVAL;
} }
/** /**