leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libata: fix ata_scmd_need_defer()

Browse Source 
Fix ata_scmd_need_defer() such that...

* whether NCQ is used or not is exactly determined using the same
  criteria as the issue path.

* defer-check is performed in all cases.

This fixes race condition where turning off NCQ on the fly causes
non-NCQ commands sneak into NCQ phase.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Tejun Heo 2007-02-20 23:27:06 +09:00 committed by Jeff Garzik
parent 6d1245bf29
commit fcf1bf1584
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ata/libata-scsi.c
View File

@ -1496,11 +1496,9 @@ static void ata_scsi_qc_complete(struct ata_queued_cmd *qc)
static int ata_scmd_need_defer(struct ata_device *dev, int is_io) static int ata_scmd_need_defer(struct ata_device *dev, int is_io)
{ {
struct ata_port *ap = dev->ap; struct ata_port *ap = dev->ap;
int is_ncq = is_io && ata_ncq_enabled(dev);
if (!(dev->flags & ATA_DFLAG_NCQ)) if (is_ncq) {
return 0;
if (is_io) {
if (!ata_tag_valid(ap->active_tag)) if (!ata_tag_valid(ap->active_tag))
return 0; return 0;
} else { } else {