leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

EDAC: highbank: Use static attribute groups for sysfs entries

Browse Source 
... instead of manual device_create_file() and device_remove_file()
calls.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: http://lkml.kernel.org/r/1423046938-18111-9-git-send-email-tiwai@suse.de
Signed-off-by: Borislav Petkov <bp@suse.de>
This commit is contained in:
Takashi Iwai 2015-02-04 11:48:58 +01:00 committed by Borislav Petkov
parent 1bf06a0d55
commit fc7cc6b782
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/edac/highbank_mc_edac.c
View File

@ -124,6 +124,13 @@ static ssize_t highbank_mc_inject_ctrl(struct device *dev,
static DEVICE_ATTR(inject_ctrl, S_IWUSR, NULL, highbank_mc_inject_ctrl); static DEVICE_ATTR(inject_ctrl, S_IWUSR, NULL, highbank_mc_inject_ctrl);
static struct attribute *highbank_dev_attrs[] = {
&dev_attr_inject_ctrl.attr,
NULL
};
ATTRIBUTE_GROUPS(highbank_dev);
struct hb_mc_settings { struct hb_mc_settings {
int err_offset; int err_offset;
int int_offset; int int_offset;
@ -231,7 +238,7 @@ static int highbank_mc_probe(struct platform_device *pdev)
dimm->mtype = MEM_DDR3; dimm->mtype = MEM_DDR3;
dimm->edac_mode = EDAC_SECDED; dimm->edac_mode = EDAC_SECDED;
res = edac_mc_add_mc(mci); res = edac_mc_add_mc_with_groups(mci, highbank_dev_groups);
if (res < 0) if (res < 0)
goto err; goto err;
@ -243,8 +250,6 @@ static int highbank_mc_probe(struct platform_device *pdev)
goto err2; goto err2;
} }
device_create_file(&mci->dev, &dev_attr_inject_ctrl);
devres_close_group(&pdev->dev, NULL); devres_close_group(&pdev->dev, NULL);
return 0; return 0;
err2: err2:
@ -259,7 +264,6 @@ static int highbank_mc_remove(struct platform_device *pdev)
{ {
struct mem_ctl_info *mci = platform_get_drvdata(pdev); struct mem_ctl_info *mci = platform_get_drvdata(pdev);
device_remove_file(&mci->dev, &dev_attr_inject_ctrl);
edac_mc_del_mc(&pdev->dev); edac_mc_del_mc(&pdev->dev);
edac_mc_free(mci); edac_mc_free(mci);
return 0; return 0;