leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc/perf/hv-24x7: Move debug prints to separate function

Browse Source 
To simplify/cleanup code, move the rather long printk() to a separate
function.

Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Sukadev Bhattiprolu 2015-03-30 18:53:42 -07:00 committed by Michael Ellerman
parent 8079876497
commit f954825dd9
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
arch/powerpc/perf/hv-24x7.c
View File

@ -985,6 +985,21 @@ static const struct attribute_group *attr_groups[] = {
NULL, NULL,
}; };
static void log_24x7_hcall(struct hv_24x7_request_buffer *request_buffer,
struct hv_24x7_data_result_buffer *result_buffer,
unsigned long ret)
{
struct hv_24x7_request *req;
req = &request_buffer->requests[0];
pr_notice_ratelimited("hcall failed: [%d %#x %#x %d] => "
"ret 0x%lx (%ld) detail=0x%x failing ix=%x\n",
req->performance_domain, req->data_offset,
req->starting_ix, req->starting_lpar_ix, ret, ret,
result_buffer->detailed_rc,
result_buffer->failing_request_ix);
}
static unsigned long single_24x7_request(struct perf_event *event, u64 *count) static unsigned long single_24x7_request(struct perf_event *event, u64 *count)
{ {
u16 idx; u16 idx;
@ -1032,12 +1047,7 @@ static unsigned long single_24x7_request(struct perf_event *event, u64 *count)
virt_to_phys(result_buffer), H24x7_DATA_BUFFER_SIZE); virt_to_phys(result_buffer), H24x7_DATA_BUFFER_SIZE);
if (ret) { if (ret) {
pr_devel_ratelimited("hcall failed: %d %#x %#x %d => " log_24x7_hcall(request_buffer, result_buffer, ret);
"0x%lx (%ld) detail=0x%x failing ix=%x\n",
req->performance_domain, req->data_offset,
idx, req->starting_lpar_ix, ret, ret,
result_buffer->detailed_rc,
result_buffer->failing_request_ix);
goto out; goto out;
} }