leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

f2fs: fix wrong return value of f2fs_acl_create

Browse Source 
When call f2fs_acl_create_masq() failed, the caller f2fs_acl_create()
should return -EIO instead of -ENOMEM, this patch makes it consistent
with posix_acl_create() which has been fixed in commit beaf226b86
("posix_acl: don't ignore return value of posix_acl_create_masq()").

Fixes: 83dfe53c18 ("f2fs: fix reference leaks in f2fs_acl_create")
Signed-off-by: Tiezhu Yang <kernelpatch@126.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Tiezhu Yang
2018-11-21 07:21:38 +08:00
committed by Jaegeuk Kim
parent f5d5510e73
commit f6176473a0
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
fs/f2fs/acl.c
View File

@@ -352,12 +352,14 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode,
return PTR_ERR(p); return PTR_ERR(p);
clone = f2fs_acl_clone(p, GFP_NOFS); clone = f2fs_acl_clone(p, GFP_NOFS);
if (!clone) if (!clone) {
goto no_mem; ret = -ENOMEM;
goto release_acl;
}
ret = f2fs_acl_create_masq(clone, mode); ret = f2fs_acl_create_masq(clone, mode);
if (ret < 0) if (ret < 0)
goto no_mem_clone; goto release_clone;
if (ret == 0) if (ret == 0)
posix_acl_release(clone); posix_acl_release(clone);
@@ -371,11 +373,11 @@ static int f2fs_acl_create(struct inode *dir, umode_t *mode,
return 0; return 0;
no_mem_clone: release_clone:
posix_acl_release(clone); posix_acl_release(clone);
no_mem: release_acl:
posix_acl_release(p); posix_acl_release(p);
return -ENOMEM; return ret;
} }
int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage, int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage,