leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

irqdomain: Improve diagnostics when a domain mapping fails

Browse Source 
When the map operation fails log the error code we get and add a WARN_ON()
so we get a backtrace (which should help work out which interrupt is the
source of the issue).

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
Mark Brown 2012-07-20 10:33:19 +01:00 committed by Grant Likely
parent 4c0946c474
commit f5a1ad057e
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
kernel/irq/irqdomain.c
View File

@ -415,7 +415,7 @@ int irq_domain_associate_many(struct irq_domain *domain, unsigned int irq_base,
{ {
unsigned int virq = irq_base; unsigned int virq = irq_base;
irq_hw_number_t hwirq = hwirq_base; irq_hw_number_t hwirq = hwirq_base;
int i; int i, ret;
pr_debug("%s(%s, irqbase=%i, hwbase=%i, count=%i)\n", __func__, pr_debug("%s(%s, irqbase=%i, hwbase=%i, count=%i)\n", __func__,
of_node_full_name(domain->of_node), irq_base, (int)hwirq_base, count); of_node_full_name(domain->of_node), irq_base, (int)hwirq_base, count);
@ -436,11 +436,16 @@ int irq_domain_associate_many(struct irq_domain *domain, unsigned int irq_base,
irq_data->hwirq = hwirq; irq_data->hwirq = hwirq;
irq_data->domain = domain; irq_data->domain = domain;
if (domain->ops->map && domain->ops->map(domain, virq, hwirq)) { if (domain->ops->map) {
pr_err("irq-%i==>hwirq-0x%lx mapping failed\n", virq, hwirq); ret = domain->ops->map(domain, virq, hwirq);
irq_data->domain = NULL; if (ret != 0) {
irq_data->hwirq = 0; pr_err("irq-%i==>hwirq-0x%lx mapping failed: %d\n",
goto err_unmap; virq, hwirq, ret);
WARN_ON(1);
irq_data->domain = NULL;
irq_data->hwirq = 0;
goto err_unmap;
}
} }
switch (domain->revmap_type) { switch (domain->revmap_type) {