leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RDS: Clean up error handling in rds_cmsg_rdma_args

Browse Source 
We don't need to set ret = 0 at the end -- it's initialized to 0.

Also, don't increment s_send_rdma stat if we're exiting with an
error.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andy Grover 2010-10-28 15:40:57 +00:00 committed by David S. Miller
parent a09f69c49b
commit f4a3fc03c1
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/rds/rdma.c
View File

@ -664,13 +664,12 @@ int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm,
}
op->op_bytes = nr_bytes;
ret = 0;
out:
kfree(pages);
if (ret)
rds_rdma_free_op(op);
rds_stats_inc(s_send_rdma);
else
rds_stats_inc(s_send_rdma);
return ret;
}