leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

powerpc/mm: Don't lose "major" fault indication on retry

Browse Source 
If the first iteration returns VM_FAULT_MAJOR but the second
one doesn't, we fail to account the fault as a major fault.

This fixes it and brings the code in line with x86.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Benjamin Herrenschmidt
2017-07-19 14:49:44 +10:00
committed by Michael Ellerman
parent bd0d63f809
commit f43bb27ebf
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
arch/powerpc/mm/fault.c
View File

@@ -349,7 +349,7 @@ static int __do_page_fault(struct pt_regs *regs, unsigned long address,
int is_exec = TRAP(regs) == 0x400; int is_exec = TRAP(regs) == 0x400;
int is_user = user_mode(regs); int is_user = user_mode(regs);
int is_write = page_fault_is_write(error_code); int is_write = page_fault_is_write(error_code);
int fault; int fault, major = 0;
int store_update_sp = 0; int store_update_sp = 0;
#ifdef CONFIG_PPC_ICSWX #ifdef CONFIG_PPC_ICSWX
@@ -501,6 +501,7 @@ good_area:
* the fault. * the fault.
*/ */
fault = handle_mm_fault(vma, address, flags); fault = handle_mm_fault(vma, address, flags);
major |= fault & VM_FAULT_MAJOR;
/* /*
* Handle the retry right now, the mmap_sem has been released in that * Handle the retry right now, the mmap_sem has been released in that
@@ -534,7 +535,7 @@ good_area:
/* /*
* Major/minor page fault accounting. * Major/minor page fault accounting.
*/ */
if (fault & VM_FAULT_MAJOR) { if (major) {
current->maj_flt++; current->maj_flt++;
perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ, 1, regs, address); perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ, 1, regs, address);
cmo_account_page_fault(); cmo_account_page_fault();