leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IBM-EMAC: Delete an unnecessary check before the function call "of_dev_put"

Browse Source 
The of_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Markus Elfring
2015-02-03 19:47:33 +01:00
committed by David S. Miller
parent 9ba11ac04e
commit f339664c0b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/ibm/emac/core.c
View File

@@ -2367,7 +2367,7 @@ static int emac_wait_deps(struct emac_instance *dev)
err = emac_check_deps(dev, deps) ? 0 : -ENODEV; err = emac_check_deps(dev, deps) ? 0 : -ENODEV;
for (i = 0; i < EMAC_DEP_COUNT; i++) { for (i = 0; i < EMAC_DEP_COUNT; i++) {
of_node_put(deps[i].node); of_node_put(deps[i].node);
if (err && deps[i].ofdev) if (err)
of_dev_put(deps[i].ofdev); of_dev_put(deps[i].ofdev);
} }
if (err == 0) { if (err == 0) {