leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pinctrl: downgrade pinctrl_get warning when no maps are found

Browse Source 
This may be perfectly legitimate. An IP block may get re-used
across SoCs. Not all of those SoCs may need pinmux settings for the
IP block, e.g. if one SoC dedicates pins to that function but
another doesn't. The driver won't know this, and will always
attempt to set up the pinmux. The mapping table defines whether any
HW programming is actually needed.

Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
[rebased to fit the applied patch series]
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Stephen Warren 2012-02-19 23:45:51 -07:00 committed by Linus Walleij
parent 9891d98c7a
commit f026fe3d10
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/pinctrl/core.c
View File

@ -567,14 +567,16 @@ static struct pinctrl *pinctrl_get_locked(struct device *dev, const char *name)
} }
} }
/* We should have atleast one map, right */ /*
if (!num_maps) { * This may be perfectly legitimate. An IP block may get re-used
pr_err("could not find any mux maps for device %s, ID %s\n", * across SoCs. Not all of those SoCs may need pinmux settings for the
devname ? devname : "(anonymous)", * IP block, e.g. if one SoC dedicates pins to that function but
name ? name : "(undefined)"); * another doesn't. The driver won't know this, and will always
kfree(p); * attempt to set up the pinmux. The mapping table defines whether any
return ERR_PTR(-EINVAL); * HW programming is actually needed.
} */
if (!num_maps)
dev_info(dev, "zero maps found for mapping %s\n", name);
pr_debug("found %u mux maps for device %s, UD %s\n", pr_debug("found %u mux maps for device %s, UD %s\n",
num_maps, num_maps,