leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: rtl8192e: use is_zero_ether_addr() instead of memcmp()

Browse Source 
Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2012-08-23 16:50:12 +08:00 committed by Greg Kroah-Hartman
parent f6aa782f25
commit efe13d868f
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/rtl8192e/rtllib_softmac_wx.c
View File

@ -14,6 +14,8 @@
*/ */
#include <linux/etherdevice.h>
#include "rtllib.h" #include "rtllib.h"
#include "dot11d.h" #include "dot11d.h"
/* FIXME: add A freqs */ /* FIXME: add A freqs */
@ -137,7 +139,6 @@ int rtllib_wx_set_wap(struct rtllib_device *ieee,
{ {
int ret = 0; int ret = 0;
u8 zero[] = {0, 0, 0, 0, 0, 0};
unsigned long flags; unsigned long flags;
short ifup = ieee->proto_started; short ifup = ieee->proto_started;
@ -157,7 +158,7 @@ int rtllib_wx_set_wap(struct rtllib_device *ieee,
goto out; goto out;
} }
if (memcmp(temp->sa_data, zero, ETH_ALEN) == 0) { if (is_zero_ether_addr(temp->sa_data)) {
spin_lock_irqsave(&ieee->lock, flags); spin_lock_irqsave(&ieee->lock, flags);
memcpy(ieee->current_network.bssid, temp->sa_data, ETH_ALEN); memcpy(ieee->current_network.bssid, temp->sa_data, ETH_ALEN);
ieee->wap_set = 0; ieee->wap_set = 0;
@ -177,7 +178,7 @@ int rtllib_wx_set_wap(struct rtllib_device *ieee,
ieee->cannot_notify = false; ieee->cannot_notify = false;
memcpy(ieee->current_network.bssid, temp->sa_data, ETH_ALEN); memcpy(ieee->current_network.bssid, temp->sa_data, ETH_ALEN);
ieee->wap_set = (memcmp(temp->sa_data, zero, ETH_ALEN) != 0); ieee->wap_set = !is_zero_ether_addr(temp->sa_data);
spin_unlock_irqrestore(&ieee->lock, flags); spin_unlock_irqrestore(&ieee->lock, flags);