leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xfs: handle negative wbc->nr_to_write during sync writeback

Browse Source 
During data integrity (WB_SYNC_ALL) writeback, wbc->nr_to_write will
go negative on inodes with more than 1024 dirty pages due to
implementation details of write_cache_pages(). Currently XFS will
abort page clustering in writeback once nr_to_write drops below
zero, and so for data integrity writeback we will do very
inefficient page at a time allocation and IO submission for inodes
with large numbers of dirty pages.

Fix this by only aborting the page clustering code when
wbc->nr_to_write is negative and the sync mode is WB_SYNC_NONE.

Cc: <stable@kernel.org>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Dave Chinner
2010-08-24 11:44:56 +10:00
committed by Dave Chinner
parent 546a192422
commit efceab1d56
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/xfs/linux-2.6/xfs_aops.c
View File

@@ -852,8 +852,8 @@ xfs_convert_page(
SetPageUptodate(page); SetPageUptodate(page);
if (count) { if (count) {
wbc->nr_to_write--; if (--wbc->nr_to_write <= 0 &&
if (wbc->nr_to_write <= 0) wbc->sync_mode == WB_SYNC_NONE)
done = 1; done = 1;
} }
xfs_start_page_writeback(page, !page_dirty, count); xfs_start_page_writeback(page, !page_dirty, count);