leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xen-pciback: short-circuit read path used for merging write values

Browse Source 
There's no point calling xen_pcibk_config_read() here - all it'll do is
return whatever conf_space_read() returns for the field which was found
here (and which would be found there again). Also there's no point
clearing tmp_val before the call.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
This commit is contained in:
Jan Beulich 2016-07-06 00:59:35 -06:00 committed by David Vrabel
parent 585203609c
commit ee87d6d0d3
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/xen/xen-pciback/conf_space.c
View File

@ -230,10 +230,8 @@ int xen_pcibk_config_write(struct pci_dev *dev, int offset, int size, u32 value)
field_end = OFFSET(cfg_entry) + field->size; field_end = OFFSET(cfg_entry) + field->size;
if (req_end > field_start && field_end > req_start) { if (req_end > field_start && field_end > req_start) {
tmp_val = 0; err = conf_space_read(dev, cfg_entry, field_start,
&tmp_val);
err = xen_pcibk_config_read(dev, field_start,
field->size, &tmp_val);
if (err) if (err)
break; break;