leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86: Kill all traces of irq_remapping_get_irq_domain()

Browse Source 
All users are converted to use the fwspec based parent domain lookup.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20201024213535.443185-30-dwmw2@infradead.org
This commit is contained in:
David Woodhouse
2020-10-24 22:35:29 +01:00
committed by Thomas Gleixner
parent b643128b91
commit ed381fca47
7 changed files with 0 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arch/x86/include/asm/hw_irq.h
View File

@@ -40,8 +40,6 @@ enum irq_alloc_type {
X86_IRQ_ALLOC_TYPE_PCI_MSIX, X86_IRQ_ALLOC_TYPE_PCI_MSIX,
X86_IRQ_ALLOC_TYPE_DMAR, X86_IRQ_ALLOC_TYPE_DMAR,
X86_IRQ_ALLOC_TYPE_UV, X86_IRQ_ALLOC_TYPE_UV,
X86_IRQ_ALLOC_TYPE_IOAPIC_GET_PARENT,
X86_IRQ_ALLOC_TYPE_HPET_GET_PARENT,
}; };
struct ioapic_alloc_info { struct ioapic_alloc_info {

9
arch/x86/include/asm/irq_remapping.h
View File

@@ -44,9 +44,6 @@ extern int irq_remapping_reenable(int);
extern int irq_remap_enable_fault_handling(void); extern int irq_remap_enable_fault_handling(void);
extern void panic_if_irq_remap(const char *msg); extern void panic_if_irq_remap(const char *msg);
extern struct irq_domain *
irq_remapping_get_irq_domain(struct irq_alloc_info *info);
/* Create PCI MSI/MSIx irqdomain, use @parent as the parent irqdomain. */ /* Create PCI MSI/MSIx irqdomain, use @parent as the parent irqdomain. */
extern struct irq_domain * extern struct irq_domain *
arch_create_remap_msi_irq_domain(struct irq_domain *par, const char *n, int id); arch_create_remap_msi_irq_domain(struct irq_domain *par, const char *n, int id);
@@ -71,11 +68,5 @@ static inline void panic_if_irq_remap(const char *msg)
{ {
} }
static inline struct irq_domain *
irq_remapping_get_irq_domain(struct irq_alloc_info *info)
{
return NULL;
}
#endif /* CONFIG_IRQ_REMAP */ #endif /* CONFIG_IRQ_REMAP */
#endif /* __X86_IRQ_REMAPPING_H */ #endif /* __X86_IRQ_REMAPPING_H */

34
drivers/iommu/amd/iommu.c
View File

@@ -3601,10 +3601,8 @@ static int get_devid(struct irq_alloc_info *info)
{ {
switch (info->type) { switch (info->type) {
case X86_IRQ_ALLOC_TYPE_IOAPIC: case X86_IRQ_ALLOC_TYPE_IOAPIC:
case X86_IRQ_ALLOC_TYPE_IOAPIC_GET_PARENT:
return get_ioapic_devid(info->devid); return get_ioapic_devid(info->devid);
case X86_IRQ_ALLOC_TYPE_HPET: case X86_IRQ_ALLOC_TYPE_HPET:
case X86_IRQ_ALLOC_TYPE_HPET_GET_PARENT:
return get_hpet_devid(info->devid); return get_hpet_devid(info->devid);
case X86_IRQ_ALLOC_TYPE_PCI_MSI: case X86_IRQ_ALLOC_TYPE_PCI_MSI:
case X86_IRQ_ALLOC_TYPE_PCI_MSIX: case X86_IRQ_ALLOC_TYPE_PCI_MSIX:
@@ -3615,44 +3613,12 @@ static int get_devid(struct irq_alloc_info *info)
} }
} }
static struct irq_domain *get_irq_domain_for_devid(struct irq_alloc_info *info,
int devid)
{
struct amd_iommu *iommu = amd_iommu_rlookup_table[devid];
if (!iommu)
return NULL;
switch (info->type) {
case X86_IRQ_ALLOC_TYPE_IOAPIC_GET_PARENT:
case X86_IRQ_ALLOC_TYPE_HPET_GET_PARENT:
return iommu->ir_domain;
default:
WARN_ON_ONCE(1);
return NULL;
}
}
static struct irq_domain *get_irq_domain(struct irq_alloc_info *info)
{
int devid;
if (!info)
return NULL;
devid = get_devid(info);
if (devid < 0)
return NULL;
return get_irq_domain_for_devid(info, devid);
}
struct irq_remap_ops amd_iommu_irq_ops = { struct irq_remap_ops amd_iommu_irq_ops = {
.prepare = amd_iommu_prepare, .prepare = amd_iommu_prepare,
.enable = amd_iommu_enable, .enable = amd_iommu_enable,
.disable = amd_iommu_disable, .disable = amd_iommu_disable,
.reenable = amd_iommu_reenable, .reenable = amd_iommu_reenable,
.enable_faulting = amd_iommu_enable_faulting, .enable_faulting = amd_iommu_enable_faulting,
.get_irq_domain = get_irq_domain,
}; };
static void fill_msi_msg(struct msi_msg *msg, u32 index) static void fill_msi_msg(struct msi_msg *msg, u32 index)

9
drivers/iommu/hyperv-iommu.c
View File

@@ -160,18 +160,9 @@ static int __init hyperv_enable_irq_remapping(void)
return IRQ_REMAP_X2APIC_MODE; return IRQ_REMAP_X2APIC_MODE;
} }
static struct irq_domain *hyperv_get_irq_domain(struct irq_alloc_info *info)
{
if (info->type == X86_IRQ_ALLOC_TYPE_IOAPIC_GET_PARENT)
return ioapic_ir_domain;
else
return NULL;
}
struct irq_remap_ops hyperv_irq_remap_ops = { struct irq_remap_ops hyperv_irq_remap_ops = {
.prepare = hyperv_prepare_irq_remapping, .prepare = hyperv_prepare_irq_remapping,
.enable = hyperv_enable_irq_remapping, .enable = hyperv_enable_irq_remapping,
.get_irq_domain = hyperv_get_irq_domain,
}; };
#endif #endif

17
drivers/iommu/intel/irq_remapping.c
View File

@@ -1127,29 +1127,12 @@ static void prepare_irte(struct irte *irte, int vector, unsigned int dest)
irte->redir_hint = 1; irte->redir_hint = 1;
} }
static struct irq_domain *intel_get_irq_domain(struct irq_alloc_info *info)
{
if (!info)
return NULL;
switch (info->type) {
case X86_IRQ_ALLOC_TYPE_IOAPIC_GET_PARENT:
return map_ioapic_to_ir(info->devid);
case X86_IRQ_ALLOC_TYPE_HPET_GET_PARENT:
return map_hpet_to_ir(info->devid);
default:
WARN_ON_ONCE(1);
return NULL;
}
}
struct irq_remap_ops intel_irq_remap_ops = { struct irq_remap_ops intel_irq_remap_ops = {
.prepare = intel_prepare_irq_remapping, .prepare = intel_prepare_irq_remapping,
.enable = intel_enable_irq_remapping, .enable = intel_enable_irq_remapping,
.disable = disable_irq_remapping, .disable = disable_irq_remapping,
.reenable = reenable_irq_remapping, .reenable = reenable_irq_remapping,
.enable_faulting = enable_drhd_fault_handling, .enable_faulting = enable_drhd_fault_handling,
.get_irq_domain = intel_get_irq_domain,
}; };
static void intel_ir_reconfigure_irte(struct irq_data *irqd, bool force) static void intel_ir_reconfigure_irte(struct irq_data *irqd, bool force)

14
drivers/iommu/irq_remapping.c
View File

@@ -158,17 +158,3 @@ void panic_if_irq_remap(const char *msg)
if (irq_remapping_enabled) if (irq_remapping_enabled)
panic(msg); panic(msg);
} }
/**
* irq_remapping_get_irq_domain - Get the irqdomain serving the request @info
* @info: interrupt allocation information, used to identify the IOMMU device
*
* Returns pointer to IRQ domain, or NULL on failure.
*/
struct irq_domain *irq_remapping_get_irq_domain(struct irq_alloc_info *info)
{
if (!remap_ops || !remap_ops->get_irq_domain)
return NULL;
return remap_ops->get_irq_domain(info);
}

3
drivers/iommu/irq_remapping.h
View File

@@ -42,9 +42,6 @@ struct irq_remap_ops {
/* Enable fault handling */ /* Enable fault handling */
int (*enable_faulting)(void); int (*enable_faulting)(void);
/* Get the irqdomain associated to IOMMU device */
struct irq_domain *(*get_irq_domain)(struct irq_alloc_info *);
}; };
extern struct irq_remap_ops intel_irq_remap_ops; extern struct irq_remap_ops intel_irq_remap_ops;