leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dm mpath: cleanup reinstate_path() et al based on code review

Browse Source 
fail_path() will print a "Failing path ..." message but reinstate_path()
doesn't print a "Reinstating path ...".  Add that message to
reinstate_path() to add symmetry and aid system debugging.

Remove reinstate_path()'s check for the path_selector providing
.reinstate_path hook.  All path selectors provide this and any future
ones must too.

activate_path() calls pg_init_done() with SCSI_DH_DEV_OFFLINED but
pg_init_done() doesn't expicitly handle it in its swicth statement.  Add
SCSI_DH_DEV_OFFLINED to the default case.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Mike Snitzer 2016-02-20 12:49:43 -05:00
parent 9f54cec553
commit ec31f3f78a
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/md/dm-mpath.c
View File

@ -1017,12 +1017,7 @@ static int reinstate_path(struct pgpath *pgpath)
if (pgpath->is_active) if (pgpath->is_active)
goto out; goto out;
if (!pgpath->pg->ps.type->reinstate_path) { DMWARN("Reinstating path %s.", pgpath->path.dev->name);
DMWARN("Reinstate path not supported by path selector %s",
pgpath->pg->ps.type->name);
r = -EINVAL;
goto out;
}
r = pgpath->pg->ps.type->reinstate_path(&pgpath->pg->ps, &pgpath->path); r = pgpath->pg->ps.type->reinstate_path(&pgpath->pg->ps, &pgpath->path);
if (r) if (r)
@ -1207,6 +1202,7 @@ static void pg_init_done(void *data, int errors)
fail_path(pgpath); fail_path(pgpath);
errors = 0; errors = 0;
break; break;
case SCSI_DH_DEV_OFFLINED:
default: default:
/* /*
* We probably do not want to fail the path for a device * We probably do not want to fail the path for a device