leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spi: fsl-espi: improve check for SPI_QE_CPU_MODE

Browse Source 
SPI_QE_CPU_MODE doesn't exist for ESPI and is set by of_mpc8xxx_spi_probe
based on DT property "mode". This property is not defined for ESPI,
see Documentation/devicetree/bindings/spi/fsl-spi.txt.
So print an error message and bail out if SPI_QE_CPU_MODE is set.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Heiner Kallweit
2016-10-27 21:24:01 +02:00
committed by Mark Brown
parent e3cd6cf425
commit e9e128a69a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/spi/spi-fsl-espi.c
View File

@@ -583,8 +583,9 @@ static int fsl_espi_probe(struct device *dev, struct resource *mem,
goto err_probe; goto err_probe;
if (mpc8xxx_spi->flags & SPI_QE_CPU_MODE) { if (mpc8xxx_spi->flags & SPI_QE_CPU_MODE) {
mpc8xxx_spi->rx_shift = 16; dev_err(dev, "SPI_QE_CPU_MODE is not supported on ESPI!\n");
mpc8xxx_spi->tx_shift = 24; ret = -EINVAL;
goto err_probe;
} }
/* SPI controller initializations */ /* SPI controller initializations */