leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gpio: mark expected switch fall-throughs

Browse Source 
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Gustavo A. R. Silva
2017-10-13 15:43:53 -05:00
committed by Linus Walleij
parent 609aaf6a60
commit e80df7b823
3 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpio/gpio-aspeed.c
View File

@@ -411,13 +411,16 @@ static int aspeed_gpio_set_type(struct irq_data *d, unsigned int type)
switch (type & IRQ_TYPE_SENSE_MASK) { switch (type & IRQ_TYPE_SENSE_MASK) {
case IRQ_TYPE_EDGE_BOTH: case IRQ_TYPE_EDGE_BOTH:
type2 |= bit; type2 |= bit;
/* fall through */
case IRQ_TYPE_EDGE_RISING: case IRQ_TYPE_EDGE_RISING:
type0 |= bit; type0 |= bit;
/* fall through */
case IRQ_TYPE_EDGE_FALLING: case IRQ_TYPE_EDGE_FALLING:
handler = handle_edge_irq; handler = handle_edge_irq;
break; break;
case IRQ_TYPE_LEVEL_HIGH: case IRQ_TYPE_LEVEL_HIGH:
type0 |= bit; type0 |= bit;
/* fall through */
case IRQ_TYPE_LEVEL_LOW: case IRQ_TYPE_LEVEL_LOW:
type1 |= bit; type1 |= bit;
handler = handle_level_irq; handler = handle_level_irq;

1
drivers/gpio/gpio-ath79.c
View File

@@ -132,6 +132,7 @@ static int ath79_gpio_irq_set_type(struct irq_data *data,
case IRQ_TYPE_LEVEL_HIGH: case IRQ_TYPE_LEVEL_HIGH:
polarity |= mask; polarity |= mask;
/* fall through */
case IRQ_TYPE_LEVEL_LOW: case IRQ_TYPE_LEVEL_LOW:
type |= mask; type |= mask;
break; break;

4
drivers/gpio/gpio-stmpe.c
View File

@@ -299,7 +299,7 @@ static void stmpe_dbg_show_one(struct seq_file *s,
if (ret < 0) if (ret < 0)
return; return;
edge_det = !!(ret & mask); edge_det = !!(ret & mask);
/* fall through */
case STMPE1801: case STMPE1801:
rise_reg = stmpe->regs[STMPE_IDX_GPRER_LSB + bank]; rise_reg = stmpe->regs[STMPE_IDX_GPRER_LSB + bank];
fall_reg = stmpe->regs[STMPE_IDX_GPFER_LSB + bank]; fall_reg = stmpe->regs[STMPE_IDX_GPFER_LSB + bank];
@@ -312,7 +312,7 @@ static void stmpe_dbg_show_one(struct seq_file *s,
if (ret < 0) if (ret < 0)
return; return;
fall = !!(ret & mask); fall = !!(ret & mask);
/* fall through */
case STMPE801: case STMPE801:
case STMPE1600: case STMPE1600:
irqen_reg = stmpe->regs[STMPE_IDX_IEGPIOR_LSB + bank]; irqen_reg = stmpe->regs[STMPE_IDX_IEGPIOR_LSB + bank];