leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

thermal: core: Allow orderly_poweroff to be called only once

Browse Source 
thermal_zone_device_check --> thermal_zone_device_update -->
handle_thermal_trip --> handle_critical_trips --> orderly_poweroff

The above sequence happens every 250/500 mS based on the configuration.
The orderly_poweroff function is getting called every 250/500 mS.
With a full fledged file system it takes at least 5-10 Seconds to
power off gracefully.

In that period due to the thermal_zone_device_check triggering
periodically the thermal work queues bombard with
orderly_poweroff calls multiple times eventually leading to
failures in gracefully powering off the system.

Make sure that orderly_poweroff is called only once.

Signed-off-by: Keerthy <j-keerthy@ti.com>
Acked-by: Eduardo Valentin <edubezval@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
This commit is contained in:
Keerthy 2017-04-18 09:59:58 +05:30 committed by Zhang Rui
parent 39da7c509a
commit e441fd6866
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/thermal/thermal_core.c
View File

@ -45,8 +45,10 @@ static LIST_HEAD(thermal_governor_list);
static DEFINE_MUTEX(thermal_list_lock); static DEFINE_MUTEX(thermal_list_lock);
static DEFINE_MUTEX(thermal_governor_lock); static DEFINE_MUTEX(thermal_governor_lock);
static DEFINE_MUTEX(poweroff_lock);
static atomic_t in_suspend; static atomic_t in_suspend;
static bool power_off_triggered;
static struct thermal_governor *def_governor; static struct thermal_governor *def_governor;
@ -342,7 +344,12 @@ static void handle_critical_trips(struct thermal_zone_device *tz,
dev_emerg(&tz->device, dev_emerg(&tz->device,
"critical temperature reached(%d C),shutting down\n", "critical temperature reached(%d C),shutting down\n",
tz->temperature / 1000); tz->temperature / 1000);
orderly_poweroff(true); mutex_lock(&poweroff_lock);
if (!power_off_triggered) {
orderly_poweroff(true);
power_off_triggered = true;
}
mutex_unlock(&poweroff_lock);
} }
} }
@ -1463,6 +1470,7 @@ static int __init thermal_init(void)
{ {
int result; int result;
mutex_init(&poweroff_lock);
result = thermal_register_governors(); result = thermal_register_governors();
if (result) if (result)
goto error; goto error;
@ -1497,6 +1505,7 @@ error:
ida_destroy(&thermal_cdev_ida); ida_destroy(&thermal_cdev_ida);
mutex_destroy(&thermal_list_lock); mutex_destroy(&thermal_list_lock);
mutex_destroy(&thermal_governor_lock); mutex_destroy(&thermal_governor_lock);
mutex_destroy(&poweroff_lock);
return result; return result;
} }