leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cgroup: cgroup_get_from_id() must check the looked-up kn is a directory

Browse Source 
cgroup has to be one kernfs dir, otherwise kernel panic is caused,
especially cgroup id is provide from userspace.

Reported-by: Marco Patalano <mpatalan@redhat.com>
Fixes: 6b658c4863 ("scsi: cgroup: Add cgroup_get_from_id()")
Cc: Muneendra <muneendra.kumar@broadcom.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: stable@vger.kernel.org # v5.14+
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
Ming Lei
2022-09-23 19:51:19 +08:00
committed by Tejun Heo
parent a81e18e963
commit df02452f3d
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
kernel/cgroup/cgroup.c
View File

@@ -6049,6 +6049,9 @@ struct cgroup *cgroup_get_from_id(u64 id)
if (!kn) if (!kn)
goto out; goto out;
if (kernfs_type(kn) != KERNFS_DIR)
goto put;
rcu_read_lock(); rcu_read_lock();
cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv); cgrp = rcu_dereference(*(void __rcu __force **)&kn->priv);
@@ -6056,7 +6059,7 @@ struct cgroup *cgroup_get_from_id(u64 id)
cgrp = NULL; cgrp = NULL;
rcu_read_unlock(); rcu_read_unlock();
put:
kernfs_put(kn); kernfs_put(kn);
out: out:
return cgrp; return cgrp;