leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net: cxgb3_main: Fix a resource leak in a error path in 'init_one()'

Browse Source 
A call to 'kfree_skb()' is missing in the error handling path of
'init_one()'.
This is already present in 'remove_one()' but is missing here.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Christophe JAILLET 2019-08-06 10:55:12 +02:00 committed by David S. Miller
parent 5c4e2e1af3
commit debea2cd31
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
View File

@ -3269,7 +3269,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (!adapter->regs) { if (!adapter->regs) {
dev_err(&pdev->dev, "cannot map device registers\n"); dev_err(&pdev->dev, "cannot map device registers\n");
err = -ENOMEM; err = -ENOMEM;
goto out_free_adapter; goto out_free_adapter_nofail;
} }
adapter->pdev = pdev; adapter->pdev = pdev;
@ -3397,6 +3397,9 @@ out_free_dev:
if (adapter->port[i]) if (adapter->port[i])
free_netdev(adapter->port[i]); free_netdev(adapter->port[i]);
out_free_adapter_nofail:
kfree_skb(adapter->nofail_skb);
out_free_adapter: out_free_adapter:
kfree(adapter); kfree(adapter);