leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

netfilter: xt_hashlimit: fix lock imbalance

Browse Source 
syszkaller found that rcu was not held in hashlimit_mt_common()

We only need to enable BH at this point.

Fixes: bea74641e3 ("netfilter: xt_hashlimit: add rate match mode")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
Eric Dumazet 2018-02-12 08:11:48 -08:00 committed by Pablo Neira Ayuso
parent db57ccf0f2
commit de526f4012
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/netfilter/xt_hashlimit.c
View File

@ -775,7 +775,7 @@ hashlimit_mt_common(const struct sk_buff *skb, struct xt_action_param *par,
if (!dh->rateinfo.prev_window && if (!dh->rateinfo.prev_window &&
(dh->rateinfo.current_rate <= dh->rateinfo.burst)) { (dh->rateinfo.current_rate <= dh->rateinfo.burst)) {
spin_unlock(&dh->lock); spin_unlock(&dh->lock);
rcu_read_unlock_bh(); local_bh_enable();
return !(cfg->mode & XT_HASHLIMIT_INVERT); return !(cfg->mode & XT_HASHLIMIT_INVERT);
} else { } else {
goto overlimit; goto overlimit;