leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

samples/kobject/: avoid world-writable sysfs files.

Browse Source 
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.

Cc: Greg Kroah-Hartman <greg@kroah.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2014-05-14 10:33:50 +09:30
parent f92201c348
commit de5109898a
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
samples/kobject/kobject-example.c
View File

@ -40,8 +40,9 @@ static ssize_t foo_store(struct kobject *kobj, struct kobj_attribute *attr,
return count; return count;
} }
/* Sysfs attributes cannot be world-writable. */
static struct kobj_attribute foo_attribute = static struct kobj_attribute foo_attribute =
__ATTR(foo, 0666, foo_show, foo_store); __ATTR(foo, 0664, foo_show, foo_store);
/* /*
* More complex function where we determine which variable is being accessed by * More complex function where we determine which variable is being accessed by
@ -73,9 +74,9 @@ static ssize_t b_store(struct kobject *kobj, struct kobj_attribute *attr,
} }
static struct kobj_attribute baz_attribute = static struct kobj_attribute baz_attribute =
__ATTR(baz, 0666, b_show, b_store); __ATTR(baz, 0664, b_show, b_store);
static struct kobj_attribute bar_attribute = static struct kobj_attribute bar_attribute =
__ATTR(bar, 0666, b_show, b_store); __ATTR(bar, 0664, b_show, b_store);
/* /*

7
samples/kobject/kset-example.c
View File

@ -124,8 +124,9 @@ static ssize_t foo_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
return count; return count;
} }
/* Sysfs attributes cannot be world-writable. */
static struct foo_attribute foo_attribute = static struct foo_attribute foo_attribute =
__ATTR(foo, 0666, foo_show, foo_store); __ATTR(foo, 0664, foo_show, foo_store);
/* /*
* More complex function where we determine which variable is being accessed by * More complex function where we determine which variable is being accessed by
@ -157,9 +158,9 @@ static ssize_t b_store(struct foo_obj *foo_obj, struct foo_attribute *attr,
} }
static struct foo_attribute baz_attribute = static struct foo_attribute baz_attribute =
__ATTR(baz, 0666, b_show, b_store); __ATTR(baz, 0664, b_show, b_store);
static struct foo_attribute bar_attribute = static struct foo_attribute bar_attribute =
__ATTR(bar, 0666, b_show, b_store); __ATTR(bar, 0664, b_show, b_store);
/* /*
* Create a group of attributes so that we can create and destroy them all * Create a group of attributes so that we can create and destroy them all