leandrof/linux
1
0
Fork 0
forked from Minki/linux
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ARM: unwinder: fix bisection to find origin in .idx section

Browse Source 
The bisection implemented in unwind_find_origin() stopped to early.  If
there is only a single entry left to check the original code just took
the end point as origin which might be wrong.

This was introduced in commit de66a97901 ("ARM: 7187/1: fix unwinding
for XIP kernels").

Reported-and-tested-by: Nick Bowler <nbowler@elliptictech.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Uwe Kleine-König 2011-12-15 21:47:56 +01:00 committed by Linus Torvalds
parent 42ebfc61cf
commit ddf5a25c5f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/arm/kernel/unwind.c
View File

@ -160,12 +160,12 @@ static const struct unwind_idx *unwind_find_origin(
const struct unwind_idx *start, const struct unwind_idx *stop) const struct unwind_idx *start, const struct unwind_idx *stop)
{ {
pr_debug("%s(%p, %p)\n", __func__, start, stop); pr_debug("%s(%p, %p)\n", __func__, start, stop);
while (start < stop - 1) { while (start < stop) {
const struct unwind_idx *mid = start + ((stop - start) >> 1); const struct unwind_idx *mid = start + ((stop - start) >> 1);
if (mid->addr_offset >= 0x40000000) if (mid->addr_offset >= 0x40000000)
/* negative offset */ /* negative offset */
start = mid; start = mid + 1;
else else
/* positive offset */ /* positive offset */
stop = mid; stop = mid;