leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hwmon: w83795: Fan control option isn't that dangerous

Browse Source 
I have been using SENSORS_W83795_FANCTRL for several years and never
had any problem. When the driver was added, I had not tested that
part of the driver yet so I wanted to be super cautious, but time has
shown that it works just fine.

In the long run I even believe that we should drop the option and
enable the feature unconditionally. It doesn't do anything until the
user explicitly starts twiddling with sysfs attributes anyway.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Link: https://lore.kernel.org/r/20190806102123.3118bcc5@endymion
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Jean Delvare 2019-08-06 10:21:23 +02:00 committed by Guenter Roeck
parent f2ff7ceaa4
commit dbf5520511
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/hwmon/Kconfig
View File

@ -1824,17 +1824,12 @@ config SENSORS_W83795
will be called w83795. will be called w83795.
config SENSORS_W83795_FANCTRL config SENSORS_W83795_FANCTRL
bool "Include automatic fan control support (DANGEROUS)" bool "Include automatic fan control support"
depends on SENSORS_W83795 depends on SENSORS_W83795
help help
If you say yes here, support for automatic fan speed control If you say yes here, support for automatic fan speed control
will be included in the driver. will be included in the driver.
This part of the code wasn't carefully reviewed and tested yet,
so enabling this option is strongly discouraged on production
servers. Only developers and testers should enable it for the
time being.
Please also note that this option will create sysfs attribute Please also note that this option will create sysfs attribute
files which may change in the future, so you shouldn't rely files which may change in the future, so you shouldn't rely
on them being stable. on them being stable.