leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vme: fake: remove unexpected unlock in fake_master_set()

Browse Source 
image->lock is unlocked in some error handling path without take the
lock, so remove those unexpected unlock.

Fixes: 658bcdae9c ("vme: Adding Fake VME driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2016-09-17 01:57:34 +00:00 committed by Greg Kroah-Hartman
parent 58ccaae303
commit db08948b97
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/vme/bridges/vme_fake.c
View File

@ -273,7 +273,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
}
if (size & 0xFFFF) {
spin_unlock(&image->lock);
pr_err("Invalid size alignment\n");
retval = -EINVAL;
goto err_window;
@ -292,7 +291,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
case VME_D32:
break;
default:
spin_unlock(&image->lock);
pr_err("Invalid data width\n");
retval = -EINVAL;
goto err_dwidth;
@ -311,7 +309,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
case VME_USER4:
break;
default:
spin_unlock(&image->lock);
pr_err("Invalid address space\n");
retval = -EINVAL;
goto err_aspace;