leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

coresight: tpiu: Allow tpiu to be built as a module

Browse Source 
Allow to build coresight-tpiu as a module, for ease of development.

- Kconfig becomes a tristate, to allow =m
- add a tpiu_remove function, for module unload
- add a MODULE_DEVICE_TABLE for autoloading on boot

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russell King <linux@armlinux.org.uk>
Reviewed-by: Mike Leach <mike.leach@linaro.org>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20200928163513.70169-13-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kim Phillips 2020-09-28 10:35:00 -06:00 committed by Greg Kroah-Hartman
parent 529c4451df
commit d9ed244ef8
2 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hwtracing/coresight/Kconfig
View File

@ -46,7 +46,7 @@ config CORESIGHT_CATU
mode where the address is not translated. mode where the address is not translated.
config CORESIGHT_SINK_TPIU config CORESIGHT_SINK_TPIU
bool "Coresight generic TPIU driver" tristate "Coresight generic TPIU driver"
depends on CORESIGHT_LINKS_AND_SINKS depends on CORESIGHT_LINKS_AND_SINKS
help help
This enables support for the Trace Port Interface Unit driver, This enables support for the Trace Port Interface Unit driver,
@ -56,6 +56,9 @@ config CORESIGHT_SINK_TPIU
connected to an external host for use case capturing more traces than connected to an external host for use case capturing more traces than
the on-board coresight memory can handle. the on-board coresight memory can handle.
To compile this driver as a module, choose M here: the
module will be called coresight-tpiu.
config CORESIGHT_SINK_ETBV10 config CORESIGHT_SINK_ETBV10
tristate "Coresight ETBv1.0 driver" tristate "Coresight ETBv1.0 driver"
depends on CORESIGHT_LINKS_AND_SINKS depends on CORESIGHT_LINKS_AND_SINKS

20
drivers/hwtracing/coresight/coresight-tpiu.c
View File

@ -173,6 +173,15 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id)
return PTR_ERR(drvdata->csdev); return PTR_ERR(drvdata->csdev);
} }
static int __exit tpiu_remove(struct amba_device *adev)
{
struct tpiu_drvdata *drvdata = dev_get_drvdata(&adev->dev);
coresight_unregister(drvdata->csdev);
return 0;
}
#ifdef CONFIG_PM #ifdef CONFIG_PM
static int tpiu_runtime_suspend(struct device *dev) static int tpiu_runtime_suspend(struct device *dev)
{ {
@ -216,6 +225,8 @@ static const struct amba_id tpiu_ids[] = {
{ 0, 0}, { 0, 0},
}; };
MODULE_DEVICE_TABLE(amba, tpiu_ids);
static struct amba_driver tpiu_driver = { static struct amba_driver tpiu_driver = {
.drv = { .drv = {
.name = "coresight-tpiu", .name = "coresight-tpiu",
@ -224,6 +235,13 @@ static struct amba_driver tpiu_driver = {
.suppress_bind_attrs = true, .suppress_bind_attrs = true,
}, },
.probe = tpiu_probe, .probe = tpiu_probe,
.remove = tpiu_remove,
.id_table = tpiu_ids, .id_table = tpiu_ids,
}; };
builtin_amba_driver(tpiu_driver);
module_amba_driver(tpiu_driver);
MODULE_AUTHOR("Pratik Patel <pratikp@codeaurora.org>");
MODULE_AUTHOR("Mathieu Poirier <mathieu.poirier@linaro.org>");
MODULE_DESCRIPTION("Arm CoreSight TPIU (Trace Port Interface Unit) driver");
MODULE_LICENSE("GPL v2");