leandrof/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

usb: cdc-wdm: Fix race between disconnect and debug messages

Browse Source 
dev_dbg() and dev_err() cannot be used to report failures
that may have been caused by a device's removal

Signed-off-by: Oliver Neukum <neukum@b1-systems.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Oliver Neukum 2010-02-27 20:55:26 +01:00 committed by Greg Kroah-Hartman
parent 922a5eadd5
commit d855fe2e9c
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/class/cdc-wdm.c
View File

@ -435,11 +435,8 @@ retry:
spin_lock_irq(&desc->iuspin); spin_lock_irq(&desc->iuspin);
if (desc->rerr) { /* read completed, error happened */ if (desc->rerr) { /* read completed, error happened */
int t = desc->rerr;
desc->rerr = 0; desc->rerr = 0;
spin_unlock_irq(&desc->iuspin); spin_unlock_irq(&desc->iuspin);
dev_err(&desc->intf->dev,
"reading had resulted in %d\n", t);
rv = -EIO; rv = -EIO;
goto err; goto err;
} }
@ -477,8 +474,6 @@ retry:
err: err:
mutex_unlock(&desc->lock); mutex_unlock(&desc->lock);
if (rv < 0 && rv != -EAGAIN)
dev_err(&desc->intf->dev, "wdm_read: exit error\n");
return rv; return rv;
} }